FIX #2918 Add option for default language for file descriptions #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
=========================================
- Coverage 3.69% 3.67% -0.02%
=========================================
Files 246 247 +1
Lines 12219 12262 +43
Branches 1083 1088 +5
=========================================
Hits 451 451
- Misses 11734 11777 +43
Partials 34 34
Continue to review full report at Codecov.
|
neslihanturan
requested changes
Nov 13, 2019
Collaborator
neslihanturan
left a comment
There was a problem hiding this comment.
Hi @OlgaMorales thanksa lot for your very first contribution. there are some problems that I see at first sight. Can you please revert all irrelevant changes included adding extra spaces etc. Add diff tab of your Pr page there should only be relevant changes. Then we can review your PR.
Author
|
During that time I had a problem with this account so my PR was made again
with other credentials, I'll check what happened with that.
…On Wed, 13 Nov 2019, 09:30 neslihanturan, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @OlgaMorales <https://github.com/OlgaMorales> thanksa lot for your
very first contribution. there are some problems that I see at first sight.
Can you please revert all irrelevant changes included adding extra spaces
etc. Add diff tab of your Pr page there should only be relevant changes.
Then we can review your PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2946?email_source=notifications&email_token=ALQAHMMNIGYSQ7O3NSIG4CTQTQMSBA5CNFSM4HMTZRMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLNNRIA#pullrequestreview-316332192>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQAHMIO2VKCSRFFQEF7G7DQTQMSBANCNFSM4HMTZRMA>
.
|
Collaborator
|
@neslihanturan I think this issue was fixed in #3020 should we close this? |
Collaborator
Thanks @madhurgupta10 , we should close indeed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did some changes in order to allow setting a default language description in settings section.
I saved that value in SharedPreferences as well.
Fixes #2918 Add option for default language for file descriptions
