Fix #2881 (Change Media Details UI) #2954

ujjwalagrawal17 · 2019-05-17T14:51:53Z

Description (required)

Fix #2881 (New Media Details UI)

What changes did you make and why?

Made changes in XML files

Screenshots showing what changed (optional - for UI changes)

neslihanturan · 2019-05-17T14:53:50Z

This is fast @ujjwalagrawal17 , please ping me when ready for test:)

ujjwalagrawal17 · 2019-05-17T14:56:13Z

Sure @neslihanturan . You can test the UI now also but the onclicks on buttons are not working now and needs some code improvements. Will try to finish it soon.

codecov-io · 2019-05-17T15:03:39Z

Codecov Report

Merging #2954 into wikimedia-hackathon-2019 will increase coverage by <.01%.
The diff coverage is 0%.

@@                     Coverage Diff                     @@
##           wikimedia-hackathon-2019   #2954      +/-   ##
===========================================================
+ Coverage                      3.69%   3.69%   +<.01%     
===========================================================
  Files                           248     248              
  Lines                         12220   12211       -9     
  Branches                       1080    1079       -1     
===========================================================
  Hits                            451     451              
+ Misses                        11735   11726       -9     
  Partials                         34      34

Impacted Files	Coverage Δ
...ee/nrw/commons/media/MediaDetailPagerFragment.java	`0% <ø> (ø)`	⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47047e4...6a783fb. Read the comment docs.

ujjwalagrawal17 · 2019-05-18T12:04:21Z

@neslihanturan it is ready to test now.

nicolas-raoul · 2019-05-19T12:52:29Z

wow very nice! :-)

…

On Fri, May 17, 2019, 23:52 Ujjwal Agrawal ***@***.*** wrote: *Description (required)* Fix #881 <#881> (New Media Details UI) What changes did you make and why? - Made changes in XML files *Screenshots showing what changed (optional - for UI changes)* [image: WhatsApp Image 2019-05-17 at 4 48 47 PM] <https://user-images.githubusercontent.com/19607555/57936289-e0623880-78c3-11e9-8e64-3fb93d467d9d.jpeg> [image: WhatsApp Image 2019-05-17 at 4 48 47 PM (1)] <https://user-images.githubusercontent.com/19607555/57936288-df310b80-78c3-11e9-9c56-e4f794ebc599.jpeg> ------------------------------ You can view, comment on, or merge this pull request online at: #2954 Commit Summary - Media Details UI changed - XML file File Changes - *M* app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-0> (16) - *A* app/src/main/res/drawable-hdpi/ic_star_border_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-1> (0) - *A* app/src/main/res/drawable-hdpi/ic_star_filled_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-2> (0) - *A* app/src/main/res/drawable-mdpi/ic_star_border_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-3> (0) - *A* app/src/main/res/drawable-mdpi/ic_star_filled_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-4> (0) - *A* app/src/main/res/drawable-xhdpi/ic_star_border_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-5> (0) - *A* app/src/main/res/drawable-xhdpi/ic_star_filled_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-6> (0) - *A* app/src/main/res/drawable-xxhdpi/ic_star_border_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-7> (0) - *A* app/src/main/res/drawable-xxhdpi/ic_star_filled_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-8> (0) - *A* app/src/main/res/drawable-xxxhdpi/ic_star_border_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-9> (0) - *A* app/src/main/res/drawable-xxxhdpi/ic_star_filled_primary_dark_24dp.png <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-10> (0) - *A* app/src/main/res/drawable/ic_file_download_primary_dark_24dp.xml <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-11> (4) - *A* app/src/main/res/drawable/ic_share_primary_dark_24dp.xml <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-12> (4) - *M* app/src/main/res/layout/detail_category_item.xml <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-13> (6) - *M* app/src/main/res/layout/fragment_media_detail.xml <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-14> (527) - *M* app/src/main/res/menu/fragment_image_detail.xml <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-15> (6) - *M* app/src/main/res/values/strings.xml <https://github.com/commons-app/apps-android-commons/pull/2954/files#diff-16> (2) Patch Links: - https://github.com/commons-app/apps-android-commons/pull/2954.patch - https://github.com/commons-app/apps-android-commons/pull/2954.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2954?email_source=notifications&email_token=AAAYKBT2RXEUGMOEDLD2K5TPV3BAVA5CNFSM4HNV7CVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUNQHAQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAYKBWIJ6E7UW3BPBMTTHDPV3BAVANCNFSM4HNV7CVA> .

neslihanturan · 2019-05-25T08:38:48Z

Hi @ujjwalagrawal17 , thanks for the great job!
I got this error consistently, even after fresh install:

java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.appcompat.app.ActionBarDrawerToggle.setDrawerIndicatorEnabled(boolean)' on a null object reference
        at fr.free.nrw.commons.theme.NavigationBaseActivity.changeDrawerIconToBackButton(NavigationBaseActivity.java:59)
        at fr.free.nrw.commons.contributions.MainActivity.hideTabs(MainActivity.java:298)
        at fr.free.nrw.commons.contributions.ContributionsFragment.setMediaDetailPagerFragment(ContributionsFragment.java:317)
        at fr.free.nrw.commons.contributions.ContributionsFragment.showDetail(ContributionsFragment.java:460)
        at fr.free.nrw.commons.contributions.ContributionsFragment.onEvent(ContributionsFragment.java:768)
        at fr.free.nrw.commons.contributions.ContributionsListAdapter.openMediaDetail(ContributionsListAdapter.java:113)
        at fr.free.nrw.commons.contributions.ContributionsListAdapter.access$200(ContributionsListAdapter.java:22)
        at fr.free.nrw.commons.contributions.ContributionsListAdapter$1.onClick(ContributionsListAdapter.java:69)
        at fr.free.nrw.commons.contributions.ContributionViewHolder.imageClicked(ContributionViewHolder.java:152)
        at fr.free.nrw.commons.contributions.ContributionViewHolder_ViewBinding$1.doClick(ContributionViewHolder_ViewBinding.java:38)
        at butterknife.internal.DebouncingOnClickListener.onClick(DebouncingOnClickListener.java:18)
        at android.view.View.performClick(View.java:6256)
        at android.view.View$PerformClick.run(View.java:24701)
        at android.os.Handler.handleCallback(Handler.java:789)
        at android.os.Handler.dispatchMessage(Handler.java:98)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
2019-05-25 11:30:48.593 28560-28560/fr.free.nrw.commons.beta E/ACRA: ACRA caught a NullPointerException for fr.free.nrw.commons.beta
    java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.appcompat.app.ActionBarDrawerToggle.setDrawerIndicatorEnabled(boolean)' on a null object reference
        at fr.free.nrw.commons.theme.NavigationBaseActivity.changeDrawerIconToBackButton(NavigationBaseActivity.java:59)
        at fr.free.nrw.commons.contributions.MainActivity.hideTabs(MainActivity.java:298)
        at fr.free.nrw.commons.contributions.ContributionsFragment.setMediaDetailPagerFragment(ContributionsFragment.java:317)
        at fr.free.nrw.commons.contributions.ContributionsFragment.showDetail(ContributionsFragment.java:460)
        at fr.free.nrw.commons.contributions.ContributionsFragment.onEvent(ContributionsFragment.java:768)
        at fr.free.nrw.commons.contributions.ContributionsListAdapter.openMediaDetail(ContributionsListAdapter.java:113)
        at fr.free.nrw.commons.contributions.ContributionsListAdapter.access$200(ContributionsListAdapter.java:22)
        at fr.free.nrw.commons.contributions.ContributionsListAdapter$1.onClick(ContributionsListAdapter.java:69)
        at fr.free.nrw.commons.contributions.ContributionViewHolder.imageClicked(ContributionViewHolder.java:152)
        at fr.free.nrw.commons.contributions.ContributionViewHolder_ViewBinding$1.doClick(ContributionViewHolder_ViewBinding.java:38)
        at butterknife.internal.DebouncingOnClickListener.onClick(DebouncingOnClickListener.java:18)
        at android.view.View.performClick(View.java:6256)
        at android.view.View$PerformClick.run(View.java:24701)
        at android.os.Handler.handleCallback(Handler.java:789)
        at android.os.Handler.dispatchMessage(Handler.java:98)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Beta debug, API 26 emulator.

neslihanturan

I have added related crash logs, please ping me when ready for test again:)

maskaravivek · 2019-06-23T11:47:12Z

@ujjwalagrawal17 Can you take a look at the pending issues in the PR?

ujjwalagrawal17 · 2019-06-23T12:01:25Z

Yup @maskaravivek I will check it out tomorrow.

…

On Sun 23 Jun, 2019, 5:17 PM Vivek Maskara, ***@***.***> wrote: @ujjwalagrawal17 <https://github.com/ujjwalagrawal17> Can you take a look at the pending issues in the PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2954?email_source=notifications&email_token=AEVTAAYY5B7YQZWLRRPKIE3P35PEFA5CNFSM4HNV7CVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYK4RRA#issuecomment-504744132>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEVTAA2LPRSFGBVD62SYQ43P35PEFANCNFSM4HNV7CVA> .

maskaravivek · 2019-07-24T04:55:41Z

@ujjwalagrawal17 The PR has been pending for a long time. It would be great if you could fix the minor pending issues.

Let us know if you won't be able to work on it so that we can assign it to someone else. :)

maskaravivek · 2019-11-30T06:25:52Z

Merging it to wikimedia-hackathon-2019. We can fix the pending issues in the hackathon branch.

Media Details UI changed - XML file

3e47fe6

ujjwalagrawal17 requested a review from maskaravivek May 17, 2019 14:51

ujjwalagrawal17 changed the title ~~[WIP] Fix #881 (Change Media Details UI)~~ [WIP] Fix #2881 (Change Media Details UI) May 17, 2019

Onclicks added, design updated

7d43748

Removed bookmark item from media detail menu

de3986c

ujjwalagrawal17 changed the base branch from master to wikimedia-hackathon-2019 May 18, 2019 12:26

misaochan approved these changes May 18, 2019

View reviewed changes

Update in XML

6a783fb

misaochan changed the title ~~[WIP] Fix #2881 (Change Media Details UI)~~ Fix #2881 (Change Media Details UI) May 18, 2019

ujjwalagrawal17 requested a review from neslihanturan May 18, 2019 14:09

maskaravivek approved these changes May 22, 2019

View reviewed changes

neslihanturan requested changes May 25, 2019

View reviewed changes

misaochan mentioned this pull request May 28, 2019

Shrink images to width of screen in media details view, and allow users to zoom to enter #2950

Closed

maskaravivek merged commit 2302fca into commons-app:wikimedia-hackathon-2019 Nov 30, 2019

maskaravivek mentioned this pull request Feb 15, 2020

Handle zoom in media details view #3414

Closed

neslihanturan mentioned this pull request Mar 12, 2020

Switch to Material Card design for the Media Detail Fragment #3436

Closed

sivaraam mentioned this pull request Mar 14, 2020

Fixes #3436 and #2881: Media Detail design Overhaul #3505

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #2881 (Change Media Details UI) #2954

Fix #2881 (Change Media Details UI) #2954

ujjwalagrawal17 commented May 17, 2019 •

edited

Loading

neslihanturan commented May 17, 2019

ujjwalagrawal17 commented May 17, 2019

codecov-io commented May 17, 2019 •

edited

Loading

ujjwalagrawal17 commented May 18, 2019

nicolas-raoul commented May 19, 2019 via email

neslihanturan commented May 25, 2019

neslihanturan left a comment

maskaravivek commented Jun 23, 2019

ujjwalagrawal17 commented Jun 23, 2019 via email

maskaravivek commented Jul 24, 2019

maskaravivek commented Nov 30, 2019

Fix #2881 (Change Media Details UI) #2954

Fix #2881 (Change Media Details UI) #2954

Conversation

ujjwalagrawal17 commented May 17, 2019 • edited Loading

neslihanturan commented May 17, 2019

ujjwalagrawal17 commented May 17, 2019

codecov-io commented May 17, 2019 • edited Loading

Codecov Report

ujjwalagrawal17 commented May 18, 2019

nicolas-raoul commented May 19, 2019 via email

neslihanturan commented May 25, 2019

neslihanturan left a comment

Choose a reason for hiding this comment

maskaravivek commented Jun 23, 2019

ujjwalagrawal17 commented Jun 23, 2019 via email

maskaravivek commented Jul 24, 2019

maskaravivek commented Nov 30, 2019

ujjwalagrawal17 commented May 17, 2019 •

edited

Loading

codecov-io commented May 17, 2019 •

edited

Loading