Skip to content

Remove unnecessary Integer.toString() calls #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2019

Conversation

Deskana
Copy link
Contributor

@Deskana Deskana commented May 18, 2019

Remove unnecessary Integer.toString() calls

In cases where an integer is directly concatenated onto a string, toString() is not needed because it is called implicitly; this patch removes the calls to improve code readability.

Tests performed (required)

Tested prodDebug on Pixel 2 emulator with API level 25.

Screenshots showing what changed

Code style and performance improvement, so no screenshots.

In cases where an integer is directly concatenated onto a string, toString() is not needed because it is called implicitly; this patch removes the calls to improve code readability.
@codecov-io
Copy link

Codecov Report

Merging #2959 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2959   +/-   ##
======================================
  Coverage    3.69%   3.69%           
======================================
  Files         247     247           
  Lines       12214   12214           
  Branches     1081    1081           
======================================
  Hits          451     451           
  Misses      11729   11729           
  Partials       34      34
Impacted Files Coverage Δ
...nrw/commons/achievements/AchievementsActivity.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/upload/UploadActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877c669...146921f. Read the comment docs.

@misaochan misaochan merged commit b176515 into commons-app:master May 19, 2019
@misaochan
Copy link
Member

Thanks @Deskana !

@Deskana Deskana deleted the removetostring branch May 19, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants