Refactor onRequestPermissionsResult to be simpler #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onRequestPermissionsResult has a switch statement with a single case, and a functionally empty default; this patch refactors it into an if statement to simplify the code. This patch also changes a C-style array declaration (String permissions[]) to the more standard Java style (String[] permissions).
Codecov Report
@@ Coverage Diff @@
## master #2965 +/- ##
=========================================
+ Coverage 3.69% 3.69% +<.01%
=========================================
Files 247 247
Lines 12214 12213 -1
Branches 1081 1081
=========================================
Hits 451 451
+ Misses 11729 11728 -1
Partials 34 34
Continue to review full report at Codecov.
|
neslihanturan
approved these changes
May 24, 2019
Collaborator
neslihanturan
left a comment
There was a problem hiding this comment.
Thanks @Deskana !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor onRequestPermissionsResult to be simpler
onRequestPermissionsResult has a switch statement with a single case, and a functionally empty default; this patch refactors it into an if statement to simplify the code. This patch also changes a C-style array declaration (String permissions[]) to the more standard Java style (String[] permissions). There's no change in functionality, just in code style.
Tests performed
Tested prodDebug on Pixel 2 emulator with API level 25.
Screenshots showing what changed
No change in functionality, so no screenshots.