Skip to content

BugFix Issue #2991 #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)
Path Segments need not be preceded by "/"

Fixes #2991 Double slash in URL

What changes did you make and why?
Removed "/" from path segments
Tests performed (required)

Tested {build variant, ProdDebug} on Samsung S7 with API level 27

Path Segmens need not be preceeded by "/"
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

@codecov-io
Copy link

Codecov Report

Merging #2992 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2992   +/-   ##
======================================
  Coverage    3.69%   3.69%           
======================================
  Files         249     249           
  Lines       12270   12270           
  Branches     1090    1090           
======================================
  Hits          453     453           
  Misses      11782   11782           
  Partials       35      35
Impacted Files Coverage Δ
...fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java 0.84% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e43ef...f7815cc. Read the comment docs.

@maskaravivek maskaravivek merged commit aabcd0e into commons-app:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double slash in URL
3 participants