With attribution enabled for OSM #2997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@maskaravivek you can click here to see the review status or cancel the code review job.
misaochan
approved these changes
Jun 9, 2019
neslihanturan
approved these changes
Jun 10, 2019
|
I don't know why is travis still in progress. Will merge after it is done. |
|
Actually travis has passed but somehow it wasn't able to notify Github about it. I saw the same happening for a few other PRs.
|
|
Weird... What should be our policy for such cases? I will go ahead and merge this time since changes probably safe. |
|
I think it's OK to merge as long as the Travis site itself says the build passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #2911
What changes did you make and why?
Enabled attribution as per https://docs.mapbox.com/help/how-mapbox-works/attribution/#mapbox-maps-sdk-for-android
Tests performed (required)
Tested on prodDebug
Screenshots showing what changed (optional - for UI changes)