fix the the dialog box error and the user talk issue #3009
Conversation
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@sherlockbeard you can click here to see the review status or cancel the code review job.
Codecov Report
@@ Coverage Diff @@
## master #3009 +/- ##
=========================================
- Coverage 3.74% 3.74% -0.01%
=========================================
Files 249 249
Lines 12090 12102 +12
Branches 1070 1070
=========================================
Hits 453 453
- Misses 11603 11615 +12
Partials 34 34
Continue to review full report at Codecov.
|
|
fixed the #2703. as they both were interdependent. |
|
When you are finished testing, please provide a link to the talk page(s) that were edited by the app, thanks :-) |
| dialog.show(); | ||
| if (isDeleted) { | ||
| dialog.getButton(AlertDialog.BUTTON_POSITIVE).setEnabled(false); | ||
| } |
There was a problem hiding this comment.
It seems that you have reformatted the code? That makes it difficult to see what has actually changed. Better send a first pull request with only the real changes, and then optionally later a second pull request with only the reformatting. Thanks! :-)
| mwApi.appendEdit(editToken, userPageString + "\n", | ||
| "User_Talk:" + sessionManager.getCurrentAccount().name, summary); | ||
| "User_Talk:" + media.getCreator(), summary); | ||
|
|
| okButton.setEnabled(false); | ||
| } else { | ||
| okButton.setEnabled(true); | ||
| else { |
There was a problem hiding this comment.
Same thing @nicolas-raoul pointed happened here too. Indentation of several lines are changed. Reviewers click "files changed" tab on your pull request page and see changed lines. When you made additional changes it is hard to understand for us what will be inserted into our code base if we merge this changes. Even if your additional changes are beneficial for code quality etc. please send them in separate pull request. We should be seeing only relevant lines changed under a single pull request.
|
@nicolas-raoul @neslihanturan i have created a new pr with all the changes requested . #3014 |
#2827 is fixed with this . the title with drop down is show only when the user is trying delete his own upload . and the dialog with text appear when user is trying to nominate someone else picture.