Skip to content

bugfix/uploads #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 12, 2019
Merged

bugfix/uploads #3012

Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4e1cbba
merged with master
ashishkumar468 Jun 9, 2019
aa86057
BugFix IllegalStateException
ashishkumar468 Jun 9, 2019
b7685d5
BugFix, clear selected categoris for previous upload session
ashishkumar468 Jun 9, 2019
c8985bd
Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/Uploa…
ashishkumar468 Jun 9, 2019
bce2b78
Added class level JavaDoc UploadRemoteDataSource
ashishkumar468 Jun 9, 2019
1eb2bc6
Added class level JavaDoc for UploadRepository
ashishkumar468 Jun 9, 2019
196c27c
Added JavaDocs for ThumbnailsAdapter
ashishkumar468 Jun 9, 2019
f239425
Added JavaDocs for MediaLicensePresenter, CategoriesPresenter
ashishkumar468 Jun 9, 2019
2e33ef7
Removed null check on category query
ashishkumar468 Jun 9, 2019
9cde838
Attached image scale listener to upload media image
ashishkumar468 Jun 2, 2019
185b0e4
Bug fix, reduced the add description edit text clickable bound
ashishkumar468 May 29, 2019
27d768b
Added tooltip in Title in UploadMediaFragment
ashishkumar468 Jun 9, 2019
1c2eb07
BugFix recent categories
ashishkumar468 Jun 9, 2019
7d717ea
Updated test methods
ashishkumar468 Jun 9, 2019
28ed254
resolved merge conflictas
ashishkumar468 Jun 9, 2019
59e7c3a
Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroy…
ashishkumar468 Jun 11, 2019
858d71d
Merge branch 'refactor_uploads' into bugfix/uploads
ashishkumar468 Jun 11, 2019
910cf86
BugFix Illegal State Exception in ViewpPagerAdapter
ashishkumar468 Jun 12, 2019
44b177e
Remove irrelevant comment
ashishkumar468 Jun 12, 2019
473cce5
Merge branch 'refactor_uploads' into bugfix/uploads
ashishkumar468 Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ public int getTotalNumberOfSteps() {
fragments.add(mediaLicenseFragment);

uploadImagesAdapter.setFragments(fragments);
vpUpload.setOffscreenPageLimit(fragments.size());
}
}

Expand Down Expand Up @@ -430,8 +431,6 @@ public void setFragments(List<Fragment> fragments) {
}

@Override public int getCount() {
//I understand this is not the best way, I will think of something better than this
vpUpload.setOffscreenPageLimit(fragments.size());
return fragments.size();
}

Expand Down