Skip to content

Conversation

@maskaravivek
Copy link
Contributor

Description (required)

Fixes #3038

What changes did you make and why?

Had to made several minor changes to fix the peer review bugs.

Tests performed (required)

Have tested on both betaDebug and prodDebug

  • nomination for deletion works as expected
  • category check works
  • thanks works
  • next image comes as expected
  • skip image works

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@maskaravivek you can click here to see the review status or cancel the code review job.

@neslihanturan
Copy link
Collaborator

Thanks @maskaravivek , it works in general. There are some small issues that I recognized.

  • Tests failed.
  • Yes, mis-categorized button brings us to next question instead of first question with new image
  • Sending thanks says success but I didn't see any recent changes about thanks. Should I see?
  • Category check notification never ends:
    Screenshot from 2019-06-25 14-31-53

And I saw some weird pages on recent changes of beta:
Screenshot from 2019-06-25 14-33-04
Screenshot from 2019-06-25 14-32-51

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the issues I commented about.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking


Reviewed with ❤️ by PullRequest

@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #3039 into 2.11-release will increase coverage by <.01%.
The diff coverage is 3.63%.

Impacted file tree graph

@@               Coverage Diff               @@
##           2.11-release   #3039      +/-   ##
===============================================
+ Coverage          4.43%   4.43%   +<.01%     
===============================================
  Files               259     259              
  Lines             12261   12258       -3     
  Branches           1051    1049       -2     
===============================================
  Hits                544     544              
+ Misses            11678   11675       -3     
  Partials             39      39
Impacted Files Coverage Δ
...r/free/nrw/commons/review/ReviewImageFragment.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/review/ReviewActivity.java 0% <0%> (ø) ⬆️
...a/fr/free/nrw/commons/review/ReviewController.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/review/ReviewPagerAdapter.java 0% <0%> (ø) ⬆️
.../java/fr/free/nrw/commons/delete/DeleteHelper.java 52.27% <10%> (-4.36%) ⬇️
.../java/fr/free/nrw/commons/review/ReviewHelper.java 86.84% <33.33%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6673725...d99a5a0. Read the comment docs.

@nicolas-raoul
Copy link
Member

@neslihanturan I believe thanks are visible if you look at the image's history page when logged as the user who sent the thank:
Screenshot from 2019-06-26 11-29-27
Thanks are kind of private information so they are not visible by other people, I believe.

@neslihanturan
Copy link
Collaborator

After @nicolas-raoul 's help I recognized thanks is actually working.

  • The notification issue is solved. (+)
  • Tests are solved (+)
  • Category question is still brings us to next question. But we don't ask for thank if category problem exists. (-)
    Can you please re-check @maskaravivek ?

@maskaravivek
Copy link
Contributor Author

@neslihanturan Yes, makes sense we should probably show the next image. In #3038 was it a typo? You had mentioned that:

Requests category check -> Brings next question

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great. Thanks for fast responses @maskaravivek , I will merge just after tests passed.

@neslihanturan neslihanturan merged commit 5dc45a5 into commons-app:2.11-release Jun 26, 2019
maskaravivek added a commit that referenced this pull request Jun 26, 2019
* Fix bugs in peer review flow

* Fix tests

* Bug fixes

* Fix remaining issues with peer review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants