-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix bugs in peer review flow #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in peer review flow #3039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ A review job has been created and sent to the PullRequest network.
@maskaravivek you can click here to see the review status or cancel the code review job.
|
Thanks @maskaravivek , it works in general. There are some small issues that I recognized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the issues I commented about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## 2.11-release #3039 +/- ##
===============================================
+ Coverage 4.43% 4.43% +<.01%
===============================================
Files 259 259
Lines 12261 12258 -3
Branches 1051 1049 -2
===============================================
Hits 544 544
+ Misses 11678 11675 -3
Partials 39 39
Continue to review full report at Codecov.
|
|
@neslihanturan I believe thanks are visible if you look at the image's history page when logged as the user who sent the thank: |
|
After @nicolas-raoul 's help I recognized thanks is actually working.
|
|
@neslihanturan Yes, makes sense we should probably show the next image. In #3038 was it a typo? You had mentioned that: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works great. Thanks for fast responses @maskaravivek , I will merge just after tests passed.




Description (required)
Fixes #3038
What changes did you make and why?
Had to made several minor changes to fix the peer review bugs.
Tests performed (required)
Have tested on both betaDebug and prodDebug