Upgrade build tools (25) and gradle plugin (2.2.2) #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing CI is not good - I'll see if there is a workaround. |
|
I personally don't think it's too early... I can test it and merge after the failed check has been resolved. |
d6e3556 to
f7bace1
Compare
|
I've made it work. The problem was that build-tools-25 requires JDK 8 (now specified in .travis.yml) - I have been already using openjdk 8 for months so I didn't notice it was incompatible with JDK 7. If we are to have JDK 8 requirement, I think it's worth mentioning in README. |
Also, Java SDK 8 is now required by dependency.
|
Thanks @whym ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it too early?
Our code base seems to be fine with the latest build tools, there might be conflicts if you have other Android projects dependent to the older environment (23.0.3).