Skip to content

fixes the string issue #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Conversation

sherlockbeard
Copy link
Contributor

changed the all capital string value to normal capitalized values . and applied textallcap to the required places .
Fixes #2935
Fixes #2873

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@sherlockbeard you can click here to see the review status or cancel the code review job.

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #3041 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3041   +/-   ##
======================================
  Coverage    4.41%   4.41%           
======================================
  Files         259     259           
  Lines       12312   12312           
  Branches     1058    1058           
======================================
  Hits          544     544           
  Misses      11729   11729           
  Partials       39      39
Impacted Files Coverage Δ
...ava/fr/free/nrw/commons/review/ReviewActivity.java 0% <0%> (ø) ⬆️
...explore/recentsearches/RecentSearchesFragment.java 0% <0%> (ø) ⬆️
...va/fr/free/nrw/commons/explore/SearchActivity.java 0% <0%> (ø) ⬆️
...rw/commons/explore/categories/ExploreActivity.java 0% <0%> (ø) ⬆️
...nrw/commons/achievements/AchievementsActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17eb6f4...e869941. Read the comment docs.

@sherlockbeard
Copy link
Contributor Author

@neslihanturan.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by reading the code, will merge after manual tests.

@neslihanturan
Copy link
Collaborator

Thanks for your cooperation @sherlockbeard

@neslihanturan neslihanturan merged commit 4ec92c2 into commons-app:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all-capital strings in strings.xml Review buttons use all-caps
3 participants