-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Minor fixes on top of backend overhaul #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes on top of backend overhaul #3059
Conversation
Fix actions for review client Use data client library for notifications With delete helper migrated to data client With wikidata edits With notifications and modifications migrated to data client With upload migrated to retrofit Delete unused code Reuse thank interface from the library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ A review job has been created and sent to the PullRequest network.
@maskaravivek you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
…s-android-commons into backend-overhaul
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest network review has been cancelled
You can reactivate the code review job from the PullRequest dashboard - or - by adding [pr] to the title of this code review.
Codecov Report
@@ Coverage Diff @@
## backend-overhaul #3059 +/- ##
==================================================
Coverage ? 5.32%
==================================================
Files ? 268
Lines ? 11820
Branches ? 962
==================================================
Hits ? 630
Misses ? 11139
Partials ? 51
Continue to review full report at Codecov.
|
No description provided.