Skip to content

Conversation

@maskaravivek
Copy link
Contributor

No description provided.

Fix actions for review client

Use data client library for notifications

With delete helper migrated to data client

With wikidata edits

With notifications and modifications migrated to data client

With upload migrated to retrofit

Delete unused code

Reuse thank interface from the library
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@maskaravivek you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 Messages
⚠️ Due to its size, this pull request will likely have a little longer turnaround time and will probably require multiple passes from our reviewers.
📚 The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest network review has been cancelled

You can reactivate the code review job from the PullRequest dashboard - or - by adding [pr] to the title of this code review.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (backend-overhaul@1faad66). Click here to learn what that means.
The diff coverage is 47.82%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             backend-overhaul   #3059   +/-   ##
==================================================
  Coverage                    ?   5.32%           
==================================================
  Files                       ?     268           
  Lines                       ?   11820           
  Branches                    ?     962           
==================================================
  Hits                        ?     630           
  Misses                      ?   11139           
  Partials                    ?      51
Impacted Files Coverage Δ
app/src/main/java/fr/free/nrw/commons/Media.java 17.94% <ø> (ø)
...ons/explore/categories/SearchCategoryFragment.java 0% <ø> (ø)
...w/commons/contributions/ContributionsFragment.java 0% <ø> (ø)
...e/nrw/commons/category/CategoryImagesActivity.java 0% <ø> (ø)
...w/commons/category/CategoryImagesListFragment.java 0% <0%> (ø)
...ain/java/fr/free/nrw/commons/quiz/QuizChecker.java 0% <0%> (ø)
...a/fr/free/nrw/commons/category/CategoryClient.java 94.11% <100%> (ø)
...in/java/fr/free/nrw/commons/media/MediaClient.java 75% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1faad66...e3ba16d. Read the comment docs.

@maskaravivek maskaravivek merged commit 6c94a5a into commons-app:backend-overhaul Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants