Closes #3061

[ashishkumar468]

• Added null check for contribution with position in ContributionsListFragment

Description (required)

Fixes #3061 App Crashes in ContributionListFragment

What changes did you make and why?
Null checks on Contribution before extracting the uri's lastPathSegment
Tests performed (required)

Tested betaDebug on Pixel Api 27

[pullrequest]

✅ A review job has been created and sent to the PullRequest network.

---

Check the status or cancel PullRequest code review here.

[tests-checker]

Could you please add tests to make sure this change works as expected?

[codecov-io]

Codecov Report

Merging #3062 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3062      +/-   ##
=========================================
- Coverage    4.66%   4.66%   -0.01%     
=========================================
  Files         264     264              
  Lines       12359   12364       +5     
  Branches     1052    1054       +2     
=========================================
  Hits          577     577              
- Misses      11739   11744       +5     
  Partials       43      43

Impacted Files	Coverage Δ
...mmons/contributions/ContributionsListFragment.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f605c5c...1b11666. Read the comment docs.

[neslihanturan]

Thanks @ashishkumar468 for fast reply, it seems like it will prevent the NPE but do you think he cause of the NPE worth to solve? Or is it just an expected NPE?

[ashishkumar468]

@neslihanturan The NPE is happening because we are trying to fetch the id of the contribution from the cursor position and if the cursor gets closed somehow and we try to fetch the id then, null value will be returned, and that is why I have handled that. With the cursor based implementation, there are chances of the cursor getting closed when the app goes in background (Handled by the framework with the current implementation as far as I understand). An effect of this will be that in such cases, the position will not be retained on configuration changes.

[neslihanturan]

This should solve your reported issue @PavelAplevich

[pullrequest]

PullRequest network review has been cancelled

You can reactivate the code review job from the PullRequest dashboard - or - by adding [pr] to the title of this code review.

[PavelAplevich]

@neslihanturan @ashishkumar468 With this fix, app looks good. I think all works correctly

[misaochan]

Thanks @ashishkumar468 and @PavelAplevich !