Skip to content

Conversation

@maskaravivek
Copy link
Contributor

No description provided.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@maskaravivek you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
📚 The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest network review has been cancelled

You can reactivate the code review job from the PullRequest dashboard - or - by adding [pr] to the title of this code review.

@codecov-io
Copy link

Codecov Report

Merging #3063 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3063   +/-   ##
======================================
  Coverage    4.66%   4.66%           
======================================
  Files         264     264           
  Lines       12364   12364           
  Branches     1054    1054           
======================================
  Hits          577     577           
  Misses      11744   11744           
  Partials       43      43
Impacted Files Coverage Δ
...n/java/fr/free/nrw/commons/CommonsApplication.java 0% <ø> (ø) ⬆️
...a/fr/free/nrw/commons/OkHttpConnectionFactory.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828b5a3...e75415f. Read the comment docs.

@misaochan misaochan merged commit 98c7b9d into commons-app:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants