Skip to content

Conversation

@VitalyVPinchuk
Copy link
Contributor

Description (required)
Settings -> Privacy -> Manage EXIF TAGS -> all tags checked

Based upon discussion #2863 (comment) and #3043 (comment)

What changes did you make and why?
Set default values to ON for manageExifTags preference.

Tested betaDebug on emulator with API level 28.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

Codecov Report

Merging #3068 into 2.11-release will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           2.11-release   #3068      +/-   ##
===============================================
- Coverage          4.41%   4.41%   -0.01%     
===============================================
  Files               259     259              
  Lines             12309   12310       +1     
  Branches           1056    1056              
===============================================
  Hits                544     544              
- Misses            11726   11727       +1     
  Partials             39      39
Impacted Files Coverage Δ
...java/fr/free/nrw/commons/upload/FileProcessor.java 3.96% <0%> (ø) ⬆️
...fr/free/nrw/commons/settings/SettingsFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b5179...742a2ca. Read the comment docs.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VitalyVPinchuk , I tested and all EXIF was selected as expected. Additionally all EXIF was included into uploaded.

Copy link
Contributor

@maskaravivek maskaravivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the code changes. Wasn't able to manually test it.

@misaochan
Copy link
Member

Thank you, everyone! <3

@misaochan misaochan merged commit 32715d9 into commons-app:2.11-release Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants