Skip to content

[WIP] #1450 Adds filters to Nearby #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

[WIP] #1450 Adds filters to Nearby #3079

wants to merge 17 commits into from

Conversation

neslihanturan
Copy link
Collaborator

@neslihanturan neslihanturan commented Jul 18, 2019 •
edited
Loading

Description (required)

Fixes #1450 Add filters to Nearby

What changes did you make and why?

  • Nearby query is modified to fetch both places with and without images.
  • Place variable is modified to include pic url if there is any.
  • Edit Bookmark Dao to save pic information to db too
  • Places with pic is green, others are blue
  • All places are green on initial map load.

Remained steps:

  • Include places that doesn't exists anymore
  • Include UI
  • Add place type filter

tests-checker[bot]
tests-checker bot suggested changes Jul 18, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@neslihanturan
Edit bookmark location table to include pictures if there is any
2f75500
@neslihanturan
Add new parameter to toString method
71bfed9
@neslihanturan
Use green icon for places that has picture
2ae56cf
@neslihanturan
Add green icon for places that has picture
c405b79
@neslihanturan
fix problematic marker colors on first update of map, the isue was ca…
db107d0 
…used of string with spaces instead of empty string
@neslihanturan
Add place state chip item UI elements
412898e
@neslihanturan
Pass xml elements into variables
28cb652
@neslihanturan
Add search field xml element for place type
39bb8a3
@neslihanturan
Initialize searchview and make sure it gets inputs
90536db
@neslihanturan
Add listview for place types
d2d74d4
@neslihanturan
Add layout utils class to set listview height and width dynamically a…
0ff48fc 
…ccording to screen size
@neslihanturan
Change methods in LayoutUtil class with methods sets height and width…
9b8a0a2 
… according to aspect ratios
@neslihanturan
Add a list for selected items and listed items, display them together…
a98874d 
…. Design checkbox items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filters to Nearby
1 participant
@neslihanturan