Skip to content

Do not create another dialog with the same custom view - reuse the old one #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 21, 2019
Merged

Do not create another dialog with the same custom view - reuse the old one #3097

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ae16ef
Clear parent from customView if parent is not null
albendz Jul 22, 2019
8cc1817
Do not create a new dialog when a dialog with a custom view already e…
albendz Jul 28, 2019
c5ee652
remove debug code from dialog custom view parent investigation
albendz Jul 28, 2019
23d982b
Add rest file
albendz Oct 31, 2019
44247d0
Didn't mean to add that test file
albendz Oct 31, 2019
276c90e
Merge remote-tracking branch 'upstream/master'
albendz Oct 31, 2019
333073c
Merge remote-tracking branch 'origin/master' into dialogparent
albendz Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/utils/DialogUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,13 @@ private static void showAlertDialog(Activity activity,
final Runnable onNegativeBtnClick,
View customView,
boolean cancelable) {
// If the custom view already has a parent, there is already a dialog showing with the view
// This happens for on resume - return to avoid creating a second dialog - the first one
// will still show
if (customView != null && customView.getParent() != null) {
return;
}

AlertDialog.Builder builder = new AlertDialog.Builder(activity);
builder.setTitle(title);
builder.setMessage(message);
Expand Down