Issue #171 - Fixing Some Lint Warnings #3171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonSarwar
commented
Oct 15, 2019
| @@ -122,7 +123,7 @@ boolean cacheContainsKey(String term) { | |||
| Observable<CategoryItem> categoryItemObservable = gpsCategories() | |||
| .concatWith(titleCategories(imageTitleList)); | |||
| if (hasDirectCategories()) { | |||
| categoryItemObservable.concatWith(directCategories().concatWith(recentCategories())); | |||
| categoryItemObservable = categoryItemObservable.concatWith(directCategories().concatWith(recentCategories())); | |||
There was a problem hiding this comment.
This one's a bit of logic change. Just wanted to point this one out.
233a48d to
6acd285
Compare
|
Fixing conflicts now. |
Fixing Some Android Lint and SonarLint Warnings in these packages: * `fr.free.nrw.commons.bookmarks` * `fr.free.nrw.commons.bookmarks.locations` * `fr.free.nrw.commons.bookmarks.pictures` Some of the fixes were: * Switching the try/catch/finally blocks for database querying into try-with-resources blocks, with the Cursor object getting set as the closable resource * Switching a lot of field types in sqlite "Create Table Statements" from STRING to TEXT * Creating a DAOException and throwing that instead of a generic RuntimeException in a few places * Logging some Exceptions using Timber instead of `e.printStackTrace()` * A few access modifier changes to be more restrictive * Adding a private constructor to some static inner classes
Fixing Some Android Lint and SonarLint Warnings in this package: * `fr.free.nrw.commons.category` Some of the fixes were: * Switching the try/catch/finally blocks for database querying in `CategoryDao` into try-with-resources blocks, with the Cursor object getting set as the closable resource * Switching one field type in the sqlite "Create Table Statement" in CategoryDao from STRING to TEXT * Throwing the new DAOException instead of a generic RuntimeException in CategoryDao * Logging some Exceptions using Timber instead of `e.printStackTrace()` * A few access modifier changes to be more restrictive * Adding a private constructor to some static classes * Made some constant String variables for recurring Strings * Changed the switch cases with only one case into if/else statements * Added some @nonnull and @nullable annotations to methods that inherit methods that use those annotations
…lin Test Files `junit.framework` is deprecated. Replacing it with `org.junit` in 4 Kotlin Test files.
6acd285 to
e4d0d88
Compare
Codecov Report
@@ Coverage Diff @@
## master #3171 +/- ##
=========================================
+ Coverage 6.22% 6.23% +0.01%
=========================================
Files 264 265 +1
Lines 11212 11189 -23
Branches 852 846 -6
=========================================
Hits 698 698
+ Misses 10457 10434 -23
Partials 57 57
Continue to review full report at Codecov.
|
domdomegg
approved these changes
Mar 1, 2020
|
@JasonSarwar Let us know if you are still working on it! |
|
I am closing the PR for now as it seems like the author isn't working on it anymore, feel free to reopen if needed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes part of #171 Fix Lint errors/warnings
Fixing Some Android Lint and SonarLint Warnings in these packages:
fr.free.nrw.commons.bookmarksfr.free.nrw.commons.bookmarks.locationsfr.free.nrw.commons.bookmarks.picturesfr.free.nrw.commons.categorySome of the changes were:
Cursorobject getting set as the closable resourceDAOExceptionand throwing that instead of a genericRuntimeExceptionin a few places (SonarLint: RSPEC-112)e.printStackTrace()(SonarLint: RSPEC-1148)finalto a few variables that are never changed@NonNulland@Nullableannotations to methods that inherit methods that use those annotationsjunit.frameworkpackage imports in some Kotlin test classes withorg.junitbecause the former is deprecatedTests performed (required)
Ran the Gradle Tests and Tested ProdDebug on the Nexus 6 Emulator with API level 22.
Please let me know if there's anything I should change back or if there's anything I should elaborate on!