Skip to content

Conversation

@ashishkumar468
Copy link
Collaborator

Description (required)

Fixes #3217 NullPointerException at ContributionsFragment.onAuthCookieAcquire when starting the app after a few hours

What changes did you make and why?
uploadServiceIntent throws null pointer exception onActivity recreation
Tests performed (required)

Tested ProdDebug} on Pixel2 with API level 27.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

Codecov Report

Merging #3220 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3220      +/-   ##
=========================================
- Coverage    6.22%   6.22%   -0.01%     
=========================================
  Files         264     264              
  Lines       11205   11208       +3     
  Branches      851     850       -1     
=========================================
  Hits          698     698              
- Misses      10450   10453       +3     
  Partials       57      57
Impacted Files Coverage Δ
...w/commons/contributions/ContributionsFragment.java 0% <0%> (ø) ⬆️
...r/free/nrw/commons/contributions/MainActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891d9ec...0fee2d3. Read the comment docs.

@neslihanturan neslihanturan changed the title Closes #3217 Closes #3217 NullPointerException at ContributionsFragment.onAuthCookieAcquire when starting the app after a few hours Nov 25, 2019
Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't reproduce this issue but, null checking should be fine.

@neslihanturan neslihanturan merged commit 3f0c3bb into commons-app:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException at ContributionsFragment.onAuthCookieAcquire when starting the app after a few hours

3 participants