Skip to content

Fixes #3239 Typed "bridge" then tapped bridge entry #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

neslihanturan
Copy link
Collaborator

@neslihanturan neslihanturan commented Nov 29, 2019

Description (required)

Fixes #3239 Typed "bridge" then tapped bridge entry. this issue was caused the logic I used to reorder place type list after each selection so that selected item will appear at beginning. Since we are in a hurry now, I think it is better to sacrifice this small feature and prevent crash. This feature can always be added, I created the issue for this.

Note: I don't link the issue here to prevent auto closing after merge, the issue title is "Display selected place types at top" if you are interested.

Tests performed (required)

betaDebug manual tests.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

Codecov Report

Merging #3241 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3241      +/-   ##
=========================================
+ Coverage    6.09%   6.09%   +<.01%     
=========================================
  Files         270     270              
  Lines       11600   11595       -5     
  Branches      905     905              
=========================================
  Hits          707     707              
+ Misses      10836   10831       -5     
  Partials       57      57
Impacted Files Coverage Δ
.../nearby/NearbyFilterSearchRecyclerViewAdapter.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5422f...21c13ac. Read the comment docs.

@sivaraam
Copy link
Member

Note: I don't link the issue here to prevent auto closing after merge, the issue title is "Display selected place types at top" if you are interested.

Just a note, GitHub would automatically close issues only when the issue ID is prefixed by one of the following keywords:

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

@misaochan misaochan merged commit 3e5360a into commons-app:master Nov 29, 2019
@neslihanturan
Copy link
Collaborator Author

Note: I don't link the issue here to prevent auto closing after merge, the issue title is "Display selected place types at top" if you are interested.

Just a note, GitHub would automatically close issues only when the issue ID is prefixed by one of the following keywords:

* close

* closes

* closed

* fix

* fixes

* fixed

* resolve

* resolves

* resolved

I didn't know that, thanks @sivaraam !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typed "bridge" then tapped bridge entry
4 participants