Skip to content

Added more unit tests to UploadPresenter #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)
Added more unit-test cases for UploadPresenter

  • Verified by running the test cases on local machine

@codecov-io
Copy link

codecov-io commented Nov 30, 2019

Codecov Report

Merging #3250 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3250      +/-   ##
=========================================
+ Coverage    6.09%   6.15%   +0.06%     
=========================================
  Files         270     270              
  Lines       11608   11608              
  Branches      906     906              
=========================================
+ Hits          707     714       +7     
+ Misses      10844   10839       -5     
+ Partials       57      55       -2
Impacted Files Coverage Δ
...va/fr/free/nrw/commons/upload/UploadPresenter.java 74.5% <0%> (+13.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3206747...f3d5a4d. Read the comment docs.

@maskaravivek maskaravivek merged commit 88bb1d8 into commons-app:master Nov 30, 2019
@ashishkumar468 ashishkumar468 deleted the feature/add-more-upload-tests branch November 30, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants