Skip to content

Added more unit tests to UploadMediaPresenterTest #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)

Added more unit tests to Upload Media Presenter
Ran the tests on local machine

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

Codecov Report

Merging #3251 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3251      +/-   ##
=========================================
+ Coverage    6.15%   6.24%   +0.09%     
=========================================
  Files         270     270              
  Lines       11608   11608              
  Branches      906     906              
=========================================
+ Hits          714     725      +11     
+ Misses      10839   10829      -10     
+ Partials       55      54       -1
Impacted Files Coverage Δ
...mons/upload/mediaDetails/UploadMediaPresenter.java 84.28% <ø> (+15.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88bb1d8...539d760. Read the comment docs.

@maskaravivek maskaravivek merged commit 36e0f76 into commons-app:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants