Skip to content

Unit-Tests for Campaigns #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)

Added unit-tests for CampaignsPresenter

What changes did you make and why?

Fetch IO & MainThreadScheduler from AppModule in CampaignsPresenter, add unit-tests for Campaigns Presenter

Tested {betaDebug} on OnePlus-3 with API level {27}.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

Codecov Report

Merging #3258 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3258      +/-   ##
=========================================
+ Coverage    6.31%   6.54%   +0.23%     
=========================================
  Files         270     270              
  Lines       11610   11613       +3     
  Branches      906     906              
=========================================
+ Hits          733     760      +27     
+ Misses      10823   10793      -30     
- Partials       54      60       +6
Impacted Files Coverage Δ
...free/nrw/commons/campaigns/CampaignsPresenter.java 52.94% <100%> (+52.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4150e5f...82588c2. Read the comment docs.

@misaochan misaochan merged commit 7b9e792 into commons-app:master Dec 2, 2019
@ashishkumar468 ashishkumar468 deleted the feature/campaigns-unit-tests branch December 2, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants