Skip to content

Closes #3262, NPE in touching edit text drawable area while uploading images #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)

Fixes #3262 App Crashes when clicking on Title Info when uploading images

What changes did you make and why?
Handled the possibility of null drawable on the title edit-text
Tests performed (required)

Tested betaDebug on OnePlus 3T, API 27

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

Codecov Report

Merging #3263 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3263      +/-   ##
=========================================
- Coverage    6.54%   6.54%   -0.01%     
=========================================
  Files         270     270              
  Lines       11613   11617       +4     
  Branches      906     908       +2     
=========================================
  Hits          760     760              
- Misses      10793   10797       +4     
  Partials       60      60
Impacted Files Coverage Δ
...upload/mediaDetails/UploadMediaDetailFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9e792...b8da3b3. Read the comment docs.

@misaochan misaochan merged commit fa7deb3 into commons-app:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when clicking on Title Info while uploading
3 participants