Skip to content

Unit test cases for logout, session manager and reason builder #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

maskaravivek
Copy link
Member

Adds more test cases.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ashishkumar468
Copy link
Collaborator

@maskaravivek I have already added the tests for ThanksClient :P, Please sync your branch with master :)

@codecov-io
Copy link

Codecov Report

Merging #3269 into master will increase coverage by 0.18%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3269      +/-   ##
=========================================
+ Coverage    6.72%   6.91%   +0.18%     
=========================================
  Files         270     270              
  Lines       11636   11635       -1     
  Branches      908     907       -1     
=========================================
+ Hits          783     805      +22     
+ Misses      10793   10770      -23     
  Partials       60      60
Impacted Files Coverage Δ
...va/fr/free/nrw/commons/actions/PageEditClient.java 82.35% <ø> (+15.68%) ⬆️
.../java/fr/free/nrw/commons/auth/SessionManager.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/utils/ViewUtilWrapper.java 0% <0%> (ø) ⬆️
...in/java/fr/free/nrw/commons/auth/LogoutClient.java 80% <100%> (+80%) ⬆️
...java/fr/free/nrw/commons/delete/ReasonBuilder.java 69.23% <100%> (+69.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fb3b3...6495b51. Read the comment docs.

@misaochan misaochan changed the title With more unit test cases Unit test cases for logout, session manager and reason builder Dec 4, 2019
Copy link
Collaborator

@ashishkumar468 ashishkumar468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@misaochan misaochan merged commit f27749f into commons-app:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants