-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix hardcoded dimensions #3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hardcoded dimensions #3282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Why there are conflicts with java files if I have not changed that files? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr seems to contain extra changes. The only changes needed here are in the resource files. I see that some java files have also been edited. Please look into this.
I guess there are conflicts because of a recent refactoring? |
How I rebase from master? Git says that my branches are updated. |
First fetch upstream. |
…droid-commons into fix-hardcoded-dimensions
Thanks @yashk2000:
Sorry, these git operations are a bit difficult for me. I don't know what I'm doing, but somehow I've pushed two more commit with "yesterday" as date 😕. Help needed! |
Please ignore this PR, I'm going to open another to try to solve the problems. |
Fix hardcoded dimensions
Fixes #3197 The xml files contain a lot of hardcoded dimensions
Tests performed
Gradle build successfully.