solves issue #3346 now the upload limit value is assigned to 100 if the edit text is empty #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3362 +/- ##
=========================================
- Coverage 7.55% 7.54% -0.01%
=========================================
Files 258 258
Lines 11350 11356 +6
Branches 911 911
=========================================
Hits 857 857
- Misses 10428 10434 +6
Partials 65 65
Continue to review full report at Codecov.
|
|
@madhurgupta10 sir I have created the new pull request with the changes you suggested. |
|
@ashishkumar468 @maskaravivek sir please review |
|
Hi @vibhusharma101 can you please inform us about what does this changes exactly do? In issue discussions you said it is expected to display a error dialog if the text is empty, but these changes seems irrelevant. Can you explain it in more details please? |
|
@vibhusharma101 Any updates on this issue? |
|
fixed in #3521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3346
What changes did you make and why?
I changed the Settings Fragment activity and made changes in uploadLimitEdittext event listener