-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add a dialog to prompt user if location is off in Nearby when Locate me button is pressed. #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sivaraam
merged 18 commits into
commons-app:master
from
aryan-earth:add_location_off_dialog_in_nearby
Mar 18, 2020
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6669a05
Added a dialog box that pops up when location is disabled and the use…
49242bd
Renamed method showDialogagain() to enableLocationOffDialog() for bet…
d217a64
Renamed NearbyParentFragment object in LocationServiceManager to some…
fae9f4c
Removed a TODO from LocationServiceManager which was related to previ…
2e2c2a4
Made changes as recommended by @ashishkumar468 which allowed for a mo…
7e32644
Changed the behaviour of the dialog box and now it will always show u…
70dac7e
[WIP] GPS Off dialog
86a2cb9
[WIP] Some minor changes
7249ca7
Nearby now checks if network location provider is enabled or not when…
53279a7
Added location off dialog box to nearby
d969c40
Fixed a typo in NearbyParentFragment where significantly was written …
c3d74d7
Some Changes reverted
55fb948
Reverted some changes in Project.xml
ec4f1dd
Made recommended changes
0b67324
Removed unused import in LocationServiceManager
90bcdc8
Update app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyP…
7282c63
Updated strings
ac643c3
Update app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyP…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.