Skip to content

Fixes #3458 "MainActivity cannot be recreated" #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixes #3458 "MainActivity cannot be recreated" #3497

wants to merge 1 commit into from

Conversation

prince-09
Copy link

Fixes #{GitHub issue number} {MainActivity cannot be recreated #3458 fixed}

What changes did you make and why?

on the restart, I am starting the main activity again.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@macgills
Copy link
Contributor

This is not the solution. It is generally indavisable to catch an exception and try again when all android apps/screens should be able to handle being recreated.

You also need to edit the description so it reads Fixes #3458 as this is way that github uses to link this PR to that issue so when we merge this PR it auto closes that issue

@nicolas-raoul nicolas-raoul changed the title MainActivity cannot be recreated #3458 Fixes #3458 "MainActivity cannot be recreated" Mar 29, 2020
@nicolas-raoul
Copy link
Member

@prince-09 Would you mind trying to find the root cause of the crash?
Thanks :-)

@macgills
Copy link
Contributor

macgills commented May 7, 2020

This has been fixed in #3686

@macgills macgills closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants