-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Converted Config Utils to Kotlin #3674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted Config Utils to Kotlin #3674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Codecov Report
@@ Coverage Diff @@
## master #3674 +/- ##
===========================================
- Coverage 6.97% 6.97% -0.01%
Complexity 292 292
===========================================
Files 257 257
Lines 11736 11738 +2
Branches 956 956
===========================================
Hits 819 819
- Misses 10846 10848 +2
Partials 71 71
Continue to review full report at Codecov.
|
neslihanturan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR Will be evaluated after the discussion at #3673 is finalized.
Description
Fixes #3673
Tests performed
Tested betaDebug on Google Pixel 2 with API level 29.