Skip to content

Conversation

@madhurgupta10
Copy link
Collaborator

Description
Fixes #3673

Tests performed
Tested betaDebug on Google Pixel 2 with API level 29.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

codecov-io commented Apr 18, 2020

Codecov Report

Merging #3674 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3674      +/-   ##
===========================================
- Coverage      6.97%   6.97%   -0.01%     
  Complexity      292     292              
===========================================
  Files           257     257              
  Lines         11736   11738       +2     
  Branches        956     956              
===========================================
  Hits            819     819              
- Misses        10846   10848       +2     
  Partials         71      71              
Impacted Files Coverage Δ Complexity Δ
...main/java/fr/free/nrw/commons/utils/ConfigUtils.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/fr/free/nrw/commons/utils/DownloadUtils.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...fr/free/nrw/commons/media/MediaDetailFragment.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd2867...f3e5b79. Read the comment docs.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR Will be evaluated after the discussion at #3673 is finalized.

@madhurgupta10 madhurgupta10 requested a review from macgills April 20, 2020 19:05
@macgills macgills merged commit 22c2068 into commons-app:master Apr 21, 2020
@madhurgupta10 madhurgupta10 deleted the kotlin-conv-config-utils branch April 21, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert ConfigUtils to Kotlin

4 participants