#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading #3696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when uploading - fix imageview rendering code
|
Even if this were passing the tests I don't think it is ready yet, I realised I had forgot to retrieve the selected depictions and insert them at top of the list and the images began to load a bit weirdly, will investigate further |
…when uploading - show selected depictions at the top - ensure updates to nearby places are reflected
…when uploading - don't set imageUrl when the url is none
…when uploading - rewrite unit tests
Codecov Report
@@ Coverage Diff @@
## master #3696 +/- ##
===========================================
+ Coverage 7.35% 7.42% +0.06%
- Complexity 335 340 +5
===========================================
Files 292 292
Lines 12883 12874 -9
Branches 1016 1014 -2
===========================================
+ Hits 948 956 +8
+ Misses 11858 11842 -16
+ Partials 77 76 -1
Continue to review full report at Codecov.
|
…when uploading - minor cleanup
…when uploading - fix erroneous cache access
nicolas-raoul
approved these changes
Apr 24, 2020
|
I can't manually test this PR because I experience this bug #3706 and can not go further steps:/ How do you test? |
|
@neslihanturan turn do not keep activities off |
neslihanturan
approved these changes
Apr 25, 2020
There was a problem hiding this comment.
Works and improves my user experience a lot, thanks @macgills !
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…ions" step when uploading (commons-app#3696) * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - fix imageview rendering code * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - show selected depictions at the top - ensure updates to nearby places are reflected * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - don't set imageUrl when the url is none * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - rewrite unit tests * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - minor cleanup * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - fix erroneous cache access
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…ions" step when uploading (commons-app#3696) * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - fix imageview rendering code * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - show selected depictions at the top - ensure updates to nearby places are reflected * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - don't set imageUrl when the url is none * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - rewrite unit tests * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - minor cleanup * commons-app#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - fix erroneous cache access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3601
What changes did you make and why?
fix imageview rendering code
Rework Rx flow to return lists of data that are inserted into LiveData
Tests performed (required)
TestedProdDebug on Nexus5x with API level 27
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
