#3734 Refactor and convert CategoryPresenter to kotlin #3735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be a stream of lists
…tor-category-presenter # Conflicts: # app/src/main/java/fr/free/nrw/commons/category/SubCategoryListFragment.java # app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoryFragment.java
…iourSubject to PublishSubject
…trigger a search on view becoming visible
…p of CategoryModel
…tor-category-presenter # Conflicts: # app/src/main/java/fr/free/nrw/commons/repository/UploadRemoteDataSource.java # app/src/main/java/fr/free/nrw/commons/repository/UploadRepository.java # app/src/main/java/fr/free/nrw/commons/upload/categories/CategoriesPresenter.java
…tor-category-presenter
neslihanturan
approved these changes
May 15, 2020
Collaborator
neslihanturan
left a comment
There was a problem hiding this comment.
Thanks a lot @macgills !
Contributor
Author
|
@neslihanturan github isn't displaying it but clicking through to travis is showing a green build, I think this is okay to merge |
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3734
What changes did you make and why?
Tests performed (required)
Tested ProdDebug on Nexus5x with API level 27