Nearby: make list resize and display message when empty #3746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3746 +/- ##
===========================================
- Coverage 7.41% 7.26% -0.15%
+ Complexity 340 333 -7
===========================================
Files 290 290
Lines 12842 12700 -142
Branches 1004 1009 +5
===========================================
- Hits 952 923 -29
+ Misses 11815 11704 -111
+ Partials 75 73 -2 Continue to review full report at Codecov.
|
macgills
reviewed
May 14, 2020
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
Outdated
Show resolved
Hide resolved
macgills
reviewed
May 14, 2020
macgills
reviewed
May 14, 2020
macgills
reviewed
May 14, 2020
macgills
reviewed
May 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #3746 +/- ##
===========================================
- Coverage 7.41% 6.99% -0.43%
+ Complexity 340 317 -23
===========================================
Files 290 290
Lines 12842 12616 -226
Branches 1004 1005 +1
===========================================
- Hits 952 882 -70
+ Misses 11815 11666 -149
+ Partials 75 68 -7 Continue to review full report at Codecov.
|
macgills
approved these changes
May 19, 2020
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…3746) * Nearby: make list resize and display message when empty * refactored and renamed for clarity * refactoring and simplifying based on comments * refactoring and simplifying based on comments * removing vertical orientation
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…3746) * Nearby: make list resize and display message when empty * refactored and renamed for clarity * refactoring and simplifying based on comments * refactoring and simplifying based on comments * removing vertical orientation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the list of nearby places resize up to its old size, depending on the content. Handle the empty case by displaying a message.
Fixes #3727
What changes did you make and why?
Tests performed
Tested betaDebug on Pixel XL with API level 29.
Screenshots
List at full size
List resized
Message displayed when list is empty
