#3468 Switch from RvRenderer to AdapterDelegates #3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goryDepictionsRenderer
… to be easier to use
…er-delegates # Conflicts: # app/src/main/java/fr/free/nrw/commons/category/CategoryClient.java # app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java # app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.java # gradle.properties
Codecov Report
@@ Coverage Diff @@
## master #3750 +/- ##
===========================================
+ Coverage 7.01% 7.17% +0.15%
Complexity 319 319
===========================================
Files 290 292 +2
Lines 12614 12369 -245
Branches 1007 986 -21
===========================================
+ Hits 885 887 +2
+ Misses 11661 11414 -247
Partials 68 68
Continue to review full report at Codecov.
|
…er-delegates # Conflicts: # app/src/main/java/fr/free/nrw/commons/nearby/PlaceRenderer.java # app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
|
@neslihanturan has manually tested this and it looks good to me, merging. :) |
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…app#3750) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3468 fix constant import * commons-app#3468 Switch from RvRenderer to AdapterDelegates - resolve id conflict
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…app#3750) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3468 fix constant import * commons-app#3468 Switch from RvRenderer to AdapterDelegates - resolve id conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3468
What changes did you make and why?
Remove the RvRenderer dependency and replace all instances with adapterDelegates
Tests performed (required)
Tested ProdDebug on Nexus5x with API level 27