Add destroyed column to BookmarkLocation table (##3729) #3774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3774 +/- ##
========================================
Coverage 7.01% 7.02%
Complexity 319 319
========================================
Files 290 290
Lines 12614 12604 -10
Branches 1007 1003 -4
========================================
Hits 885 885
+ Misses 11661 11651 -10
Partials 68 68
Continue to review full report at Codecov.
|
macgills
reviewed
May 26, 2020
app/src/main/java/fr/free/nrw/commons/bookmarks/locations/BookmarkLocationsDao.java
Outdated
Show resolved
Hide resolved
|
@ashishkumar468 are there any further tickets for Room migration? It isn't very beneficial to the project to keep maintaining these unwieldy classes |
|
@macgills Not that I know of, this should be it :) |
|
@ashishkumar468 I'll create a ticket for converting each remaining ContentProvider so? |
|
Yes that would be great, thanks :) |
macgills
approved these changes
May 27, 2020
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…ommons-app#3774) * Add destroyed column to BookmarkLocation table (#commons-app#3729) * switch with fall through for migrations
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…ommons-app#3774) * Add destroyed column to BookmarkLocation table (#commons-app#3729) * switch with fall through for migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3729
What changes did you make and why?
location_destroyedto BookmarkLocation tableTests performed (required)
Tested {prodDebug, betaDebug} on {Pixel 2 emulator} with API level {28}.
Checked for successful database migration (on emulator) as well.