Skip to content

#3600 [structured-commons] From Nearby, "Next" button greyed out until modifying caption #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

macgills
Copy link
Contributor

Description (required)

Fixes #3600

What changes did you make and why?

  • set textwatcher first

Tests performed (required)

Tested ProdDebug on Nexus5x with API level 27

…l modifying caption - set textwatcher first
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-commenter
Copy link

Codecov Report

Merging #3809 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3809   +/-   ##
========================================
  Coverage      8.50%   8.50%           
  Complexity      366     366           
========================================
  Files           309     309           
  Lines         12428   12427    -1     
  Branches        994     994           
========================================
  Hits           1057    1057           
+ Misses        11302   11301    -1     
  Partials         69      69           
Impacted Files Coverage Δ Complexity Δ
...e/nrw/commons/upload/UploadMediaDetailAdapter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4379fd...3d477e2. Read the comment docs.

@misaochan misaochan merged commit 7cfa807 into master Jun 24, 2020
@macgills macgills deleted the macgills/3600-enable-next-with-place branch June 24, 2020 14:57
ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this pull request Oct 10, 2020
…ed out until modifying caption - set textwatcher first (commons-app#3809)
ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this pull request Oct 10, 2020
…ed out until modifying caption - set textwatcher first (commons-app#3809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[structured-commons] From Nearby, "Next" button greyed out until modifying caption
3 participants