[GSoC] Merge Leaderboard branch with master #3905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…display level in first tab & Leaderboard in the second tab (commons-app#3794) * Updated UI of achievements activity to display level in first tab and Leaderboard in the second tab * Removed hardcoded string
…ploads via mobile app (all time) and display it in the Leaderboard screen. (commons-app#3865)
* Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Fixed Bug - missing data in landscape mode * Added Unit Tests for Leaderboard * Added JavaDocs * Updated JavaDocs
* Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Fixed Bug - missing data in landscape mode * Added Unit Tests for Leaderboard * Added JavaDocs * Updated JavaDocs * Added Pagination * Added Merge Adapter * Fixed Test Case * Added Smooth Scroll * Added Progress Bar for Paging * Fixed Gradle
* Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Added option to set a new avatar
…3887) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * commons-app#3749 Improve MediaClient UnitTests (commons-app#3846) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test * commons-app#3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination * commons-app#3772 Convert SearchImagesFragment to use Pagination - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text * commons-app#3772 Convert SearchImagesFragment to use Pagination - allow viewpager to load more data * commons-app#3760 remove test that got re-added by merge * commons-app#3760 remove duplicate dependency * commons-app#3772 fix compilation * commons-app#3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version * commons-app#3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination * commons-app#3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage * commons-app#3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - align test with returned values * commons-app#3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour * commons-app#3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption * commons-app#3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes * commons-app#3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test * commons-app#3749 Improve MediaClient UnitTests - test rewrite * commons-app#3749 Improve MediaClient UnitTests - align with buildConfig property * With pause and resume for uploads (commons-app#3858) * With pause and resume for uploads * Dispose current upload * Make pause and resume work * Check stash validity * With java docs * minor * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add nearby presenter unit tests (commons-app#3615) * init the test file * Add tests to check if searchthisarea button action and checkbox actions are added after initialize test * Add tests to locked unlocked nearby cases * Add tests for null cases in updateMapAndList method * Add test to check which locations are used to populate places, depending to LocationChangeType * Add tests to test users position is not followed if blue dot (current location marker) is not visible * Add tests to decide search this area method visibility on camera move * Add tests for multi filteirng of placetypes * add tests for single place type selection too * Add tests to tests search view focus gain and bottom sheet visibilities * Add tests for SearchCloseToCurrentLocation * Remove two unneeded getter and setter for isNearbyLocked, use @VisibleForTesting annotation instead * Add VisibleForTesting annotation to initializeNearbyOperations method so that it will be private by default * Add missing tests * Add tests for map updated case and add missing lines those are being tested * Add some missind method verifications * Create real latlang objects isntead of spying them * Use a real presenter object instead of a spy * Revert nonneeded @VisibleForTest annotations, instead reach via lockUnlock method * Reduce code repetitions * Do not call a test from another test method * Add some more tests * Fix minor issues * Hidden categories are not showed in suggested categories (commons-app#3853) * Localisation updates from https://translatewiki.net. * Clarify that the caption would also be used as the image title (commons-app#3876) The app uses the fist caption as the file title. This should also be communicated to the user via the info box as they would not be aware of it otherwise. * Localisation updates from https://translatewiki.net. * Added Click event for leaderboard, Fixed commons-app#3886 * Fixed Travis Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
* Attempt to add filters * Basic Filter Working * Filter Improved * Filter Completed
nicolas-raoul
requested changes
Aug 21, 2020
app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/UserDetailAdapter.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/ViewModelFactory.java
Show resolved
Hide resolved
* Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * commons-app#3749 Improve MediaClient UnitTests (commons-app#3846) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test * commons-app#3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination * commons-app#3772 Convert SearchImagesFragment to use Pagination - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text * commons-app#3772 Convert SearchImagesFragment to use Pagination - allow viewpager to load more data * commons-app#3760 remove test that got re-added by merge * commons-app#3760 remove duplicate dependency * commons-app#3772 fix compilation * commons-app#3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version * commons-app#3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination * commons-app#3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage * commons-app#3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - align test with returned values * commons-app#3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour * commons-app#3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption * commons-app#3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes * commons-app#3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test * commons-app#3749 Improve MediaClient UnitTests - test rewrite * commons-app#3749 Improve MediaClient UnitTests - align with buildConfig property * With pause and resume for uploads (commons-app#3858) * With pause and resume for uploads * Dispose current upload * Make pause and resume work * Check stash validity * With java docs * minor * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add nearby presenter unit tests (commons-app#3615) * init the test file * Add tests to check if searchthisarea button action and checkbox actions are added after initialize test * Add tests to locked unlocked nearby cases * Add tests for null cases in updateMapAndList method * Add test to check which locations are used to populate places, depending to LocationChangeType * Add tests to test users position is not followed if blue dot (current location marker) is not visible * Add tests to decide search this area method visibility on camera move * Add tests for multi filteirng of placetypes * add tests for single place type selection too * Add tests to tests search view focus gain and bottom sheet visibilities * Add tests for SearchCloseToCurrentLocation * Remove two unneeded getter and setter for isNearbyLocked, use @VisibleForTesting annotation instead * Add VisibleForTesting annotation to initializeNearbyOperations method so that it will be private by default * Add missing tests * Add tests for map updated case and add missing lines those are being tested * Add some missind method verifications * Create real latlang objects isntead of spying them * Use a real presenter object instead of a spy * Revert nonneeded @VisibleForTest annotations, instead reach via lockUnlock method * Reduce code repetitions * Do not call a test from another test method * Add some more tests * Fix minor issues * Hidden categories are not showed in suggested categories (commons-app#3853) * Localisation updates from https://translatewiki.net. * Clarify that the caption would also be used as the image title (commons-app#3876) The app uses the fist caption as the file title. This should also be communicated to the user via the info box as they would not be aware of it otherwise. * Localisation updates from https://translatewiki.net. * Delete NearbyMapFragment & NearbyListFragment (commons-app#3885) * Fixes commons-app#3884 * Delete NearbyMapFragment & NearbyListFragment * Fixed NearbyParentFragmentPresenterTest * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add more nearby tests (commons-app#3877) * more nearby tests added * Add tests for Label class * Add checkbox test javadocs * Add javadocs for label * Localisation updates from https://translatewiki.net. * Updated strings.xml Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Co-authored-by: Ashish Kumar <ashishkumar468@gmail.com>
|
@nicolas-raoul Can we merge this now? :) |
nicolas-raoul
requested changes
Aug 26, 2020
app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardConstants.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardList.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardResponse.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/UpdateAvatarResponse.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/profile/leaderboard/UserDetailAdapter.java
Outdated
Show resolved
Hide resolved
This reverts commit 00019b5.
nicolas-raoul
requested changes
Aug 26, 2020
nicolas-raoul
approved these changes
Aug 27, 2020
|
@misaochan It works great and the code is clean, with tests and Javadoc everywhere, so I think this can be merged. What do you think? :-) |
|
Hi @nicolas-raoul and @madhurgupta10 , this PR looks great to me for the most part. :) Just one little issue, I looked at https://codecov.io/gh/commons-app/apps-android-commons/pull/3905 and it seems like it will decrease our project's code coverage by 0.23% if it is merged into master. Would it be possible to increase the unit test coverage in this PR so that it will not decrease master's when merged? But it's not a huge deal and if time is running short I am okay with merging. |
I don't think it would be possible for me to increase the code coverage before 31st (GSoC Deadline) I will surely keep it in mind and when I work on increasing the code coverage task during the 1 year time, I will add more tests to these classes as well :) |
|
Sounds good to me. |
ashishkumar468
added a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
* [GSoC] Fixes commons-app#3789 Updated UI of achievements activity to display level in first tab & Leaderboard in the second tab (commons-app#3794) * Updated UI of achievements activity to display level in first tab and Leaderboard in the second tab * Removed hardcoded string * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. (commons-app#3865) * [GSoC] Added Unit Tests and Fixed Landscape Mode Bug (commons-app#3872) * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Fixed Bug - missing data in landscape mode * Added Unit Tests for Leaderboard * Added JavaDocs * Updated JavaDocs * [GSoC] Added Pagination to Leaderboard (commons-app#3881) * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Fixed Bug - missing data in landscape mode * Added Unit Tests for Leaderboard * Added JavaDocs * Updated JavaDocs * Added Pagination * Added Merge Adapter * Fixed Test Case * Added Smooth Scroll * Added Progress Bar for Paging * Fixed Gradle * [GSoC] Added option to set a new avatar (commons-app#3892) * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Added option to set a new avatar * [GSoC] Added Click to open user profile for leaderboard (commons-app#3887) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * commons-app#3749 Improve MediaClient UnitTests (commons-app#3846) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test * commons-app#3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination * commons-app#3772 Convert SearchImagesFragment to use Pagination - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text * commons-app#3772 Convert SearchImagesFragment to use Pagination - allow viewpager to load more data * commons-app#3760 remove test that got re-added by merge * commons-app#3760 remove duplicate dependency * commons-app#3772 fix compilation * commons-app#3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version * commons-app#3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination * commons-app#3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage * commons-app#3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - align test with returned values * commons-app#3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour * commons-app#3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption * commons-app#3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes * commons-app#3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test * commons-app#3749 Improve MediaClient UnitTests - test rewrite * commons-app#3749 Improve MediaClient UnitTests - align with buildConfig property * With pause and resume for uploads (commons-app#3858) * With pause and resume for uploads * Dispose current upload * Make pause and resume work * Check stash validity * With java docs * minor * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add nearby presenter unit tests (commons-app#3615) * init the test file * Add tests to check if searchthisarea button action and checkbox actions are added after initialize test * Add tests to locked unlocked nearby cases * Add tests for null cases in updateMapAndList method * Add test to check which locations are used to populate places, depending to LocationChangeType * Add tests to test users position is not followed if blue dot (current location marker) is not visible * Add tests to decide search this area method visibility on camera move * Add tests for multi filteirng of placetypes * add tests for single place type selection too * Add tests to tests search view focus gain and bottom sheet visibilities * Add tests for SearchCloseToCurrentLocation * Remove two unneeded getter and setter for isNearbyLocked, use @VisibleForTesting annotation instead * Add VisibleForTesting annotation to initializeNearbyOperations method so that it will be private by default * Add missing tests * Add tests for map updated case and add missing lines those are being tested * Add some missind method verifications * Create real latlang objects isntead of spying them * Use a real presenter object instead of a spy * Revert nonneeded @VisibleForTest annotations, instead reach via lockUnlock method * Reduce code repetitions * Do not call a test from another test method * Add some more tests * Fix minor issues * Hidden categories are not showed in suggested categories (commons-app#3853) * Localisation updates from https://translatewiki.net. * Clarify that the caption would also be used as the image title (commons-app#3876) The app uses the fist caption as the file title. This should also be communicated to the user via the info box as they would not be aware of it otherwise. * Localisation updates from https://translatewiki.net. * Added Click event for leaderboard, Fixed commons-app#3886 * Fixed Travis Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> * [GSoC] Added Leaderboard Filters (commons-app#3902) * Attempt to add filters * Basic Filter Working * Filter Improved * Filter Completed * Add JavaDocs * Added Test for Update Avatar * Decreased Margin of Filter * [GSoC] Updated leaderboard string (commons-app#3897) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * commons-app#3749 Improve MediaClient UnitTests (commons-app#3846) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test * commons-app#3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination * commons-app#3772 Convert SearchImagesFragment to use Pagination - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text * commons-app#3772 Convert SearchImagesFragment to use Pagination - allow viewpager to load more data * commons-app#3760 remove test that got re-added by merge * commons-app#3760 remove duplicate dependency * commons-app#3772 fix compilation * commons-app#3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version * commons-app#3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination * commons-app#3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage * commons-app#3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - align test with returned values * commons-app#3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour * commons-app#3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption * commons-app#3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes * commons-app#3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test * commons-app#3749 Improve MediaClient UnitTests - test rewrite * commons-app#3749 Improve MediaClient UnitTests - align with buildConfig property * With pause and resume for uploads (commons-app#3858) * With pause and resume for uploads * Dispose current upload * Make pause and resume work * Check stash validity * With java docs * minor * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add nearby presenter unit tests (commons-app#3615) * init the test file * Add tests to check if searchthisarea button action and checkbox actions are added after initialize test * Add tests to locked unlocked nearby cases * Add tests for null cases in updateMapAndList method * Add test to check which locations are used to populate places, depending to LocationChangeType * Add tests to test users position is not followed if blue dot (current location marker) is not visible * Add tests to decide search this area method visibility on camera move * Add tests for multi filteirng of placetypes * add tests for single place type selection too * Add tests to tests search view focus gain and bottom sheet visibilities * Add tests for SearchCloseToCurrentLocation * Remove two unneeded getter and setter for isNearbyLocked, use @VisibleForTesting annotation instead * Add VisibleForTesting annotation to initializeNearbyOperations method so that it will be private by default * Add missing tests * Add tests for map updated case and add missing lines those are being tested * Add some missind method verifications * Create real latlang objects isntead of spying them * Use a real presenter object instead of a spy * Revert nonneeded @VisibleForTest annotations, instead reach via lockUnlock method * Reduce code repetitions * Do not call a test from another test method * Add some more tests * Fix minor issues * Hidden categories are not showed in suggested categories (commons-app#3853) * Localisation updates from https://translatewiki.net. * Clarify that the caption would also be used as the image title (commons-app#3876) The app uses the fist caption as the file title. This should also be communicated to the user via the info box as they would not be aware of it otherwise. * Localisation updates from https://translatewiki.net. * Delete NearbyMapFragment & NearbyListFragment (commons-app#3885) * Fixes commons-app#3884 * Delete NearbyMapFragment & NearbyListFragment * Fixed NearbyParentFragmentPresenterTest * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add more nearby tests (commons-app#3877) * more nearby tests added * Add tests for Label class * Add checkbox test javadocs * Add javadocs for label * Localisation updates from https://translatewiki.net. * Updated strings.xml Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Co-authored-by: Ashish Kumar <ashishkumar468@gmail.com> * Updated Strings * Added JavaDocs for all methods and classes * Added JavaDocs for all methods and classes * Added More JavaDocs * Revert string.xml * Revert "Revert string.xml" This reverts commit 00019b5. * Added protected * Fixed strings.xml extra changes * Revert codeStyle change * Fixed extra string change Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Co-authored-by: Ashish Kumar <ashishkumar468@gmail.com>
ashishkumar468
added a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
* [GSoC] Fixes commons-app#3789 Updated UI of achievements activity to display level in first tab & Leaderboard in the second tab (commons-app#3794) * Updated UI of achievements activity to display level in first tab and Leaderboard in the second tab * Removed hardcoded string * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. (commons-app#3865) * [GSoC] Added Unit Tests and Fixed Landscape Mode Bug (commons-app#3872) * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Fixed Bug - missing data in landscape mode * Added Unit Tests for Leaderboard * Added JavaDocs * Updated JavaDocs * [GSoC] Added Pagination to Leaderboard (commons-app#3881) * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Fixed Bug - missing data in landscape mode * Added Unit Tests for Leaderboard * Added JavaDocs * Updated JavaDocs * Added Pagination * Added Merge Adapter * Fixed Test Case * Added Smooth Scroll * Added Progress Bar for Paging * Fixed Gradle * [GSoC] Added option to set a new avatar (commons-app#3892) * Fixes commons-app#3861 Use the APIs to fetch leaderboard’s based on uploads via mobile app (all time) and display it in the Leaderboard screen. * Added option to set a new avatar * [GSoC] Added Click to open user profile for leaderboard (commons-app#3887) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * commons-app#3749 Improve MediaClient UnitTests (commons-app#3846) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test * commons-app#3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination * commons-app#3772 Convert SearchImagesFragment to use Pagination - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text * commons-app#3772 Convert SearchImagesFragment to use Pagination - allow viewpager to load more data * commons-app#3760 remove test that got re-added by merge * commons-app#3760 remove duplicate dependency * commons-app#3772 fix compilation * commons-app#3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version * commons-app#3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination * commons-app#3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage * commons-app#3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - align test with returned values * commons-app#3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour * commons-app#3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption * commons-app#3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes * commons-app#3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test * commons-app#3749 Improve MediaClient UnitTests - test rewrite * commons-app#3749 Improve MediaClient UnitTests - align with buildConfig property * With pause and resume for uploads (commons-app#3858) * With pause and resume for uploads * Dispose current upload * Make pause and resume work * Check stash validity * With java docs * minor * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add nearby presenter unit tests (commons-app#3615) * init the test file * Add tests to check if searchthisarea button action and checkbox actions are added after initialize test * Add tests to locked unlocked nearby cases * Add tests for null cases in updateMapAndList method * Add test to check which locations are used to populate places, depending to LocationChangeType * Add tests to test users position is not followed if blue dot (current location marker) is not visible * Add tests to decide search this area method visibility on camera move * Add tests for multi filteirng of placetypes * add tests for single place type selection too * Add tests to tests search view focus gain and bottom sheet visibilities * Add tests for SearchCloseToCurrentLocation * Remove two unneeded getter and setter for isNearbyLocked, use @VisibleForTesting annotation instead * Add VisibleForTesting annotation to initializeNearbyOperations method so that it will be private by default * Add missing tests * Add tests for map updated case and add missing lines those are being tested * Add some missind method verifications * Create real latlang objects isntead of spying them * Use a real presenter object instead of a spy * Revert nonneeded @VisibleForTest annotations, instead reach via lockUnlock method * Reduce code repetitions * Do not call a test from another test method * Add some more tests * Fix minor issues * Hidden categories are not showed in suggested categories (commons-app#3853) * Localisation updates from https://translatewiki.net. * Clarify that the caption would also be used as the image title (commons-app#3876) The app uses the fist caption as the file title. This should also be communicated to the user via the info box as they would not be aware of it otherwise. * Localisation updates from https://translatewiki.net. * Added Click event for leaderboard, Fixed commons-app#3886 * Fixed Travis Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> * [GSoC] Added Leaderboard Filters (commons-app#3902) * Attempt to add filters * Basic Filter Working * Filter Improved * Filter Completed * Add JavaDocs * Added Test for Update Avatar * Decreased Margin of Filter * [GSoC] Updated leaderboard string (commons-app#3897) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * commons-app#3749 Improve MediaClient UnitTests (commons-app#3846) * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer * commons-app#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes * commons-app#3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test * commons-app#3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination * commons-app#3772 Convert SearchImagesFragment to use Pagination - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text * commons-app#3772 Convert SearchImagesFragment to use Pagination - allow viewpager to load more data * commons-app#3760 remove test that got re-added by merge * commons-app#3760 remove duplicate dependency * commons-app#3772 fix compilation * commons-app#3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version * commons-app#3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination * commons-app#3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage * commons-app#3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages * commons-app#3810 Convert DepictedImagesFragment to use Pagination - align test with returned values * commons-app#3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour * commons-app#3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption * commons-app#3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes * commons-app#3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource * commons-app#3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test * commons-app#3749 Improve MediaClient UnitTests - test rewrite * commons-app#3749 Improve MediaClient UnitTests - align with buildConfig property * With pause and resume for uploads (commons-app#3858) * With pause and resume for uploads * Dispose current upload * Make pause and resume work * Check stash validity * With java docs * minor * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add nearby presenter unit tests (commons-app#3615) * init the test file * Add tests to check if searchthisarea button action and checkbox actions are added after initialize test * Add tests to locked unlocked nearby cases * Add tests for null cases in updateMapAndList method * Add test to check which locations are used to populate places, depending to LocationChangeType * Add tests to test users position is not followed if blue dot (current location marker) is not visible * Add tests to decide search this area method visibility on camera move * Add tests for multi filteirng of placetypes * add tests for single place type selection too * Add tests to tests search view focus gain and bottom sheet visibilities * Add tests for SearchCloseToCurrentLocation * Remove two unneeded getter and setter for isNearbyLocked, use @VisibleForTesting annotation instead * Add VisibleForTesting annotation to initializeNearbyOperations method so that it will be private by default * Add missing tests * Add tests for map updated case and add missing lines those are being tested * Add some missind method verifications * Create real latlang objects isntead of spying them * Use a real presenter object instead of a spy * Revert nonneeded @VisibleForTest annotations, instead reach via lockUnlock method * Reduce code repetitions * Do not call a test from another test method * Add some more tests * Fix minor issues * Hidden categories are not showed in suggested categories (commons-app#3853) * Localisation updates from https://translatewiki.net. * Clarify that the caption would also be used as the image title (commons-app#3876) The app uses the fist caption as the file title. This should also be communicated to the user via the info box as they would not be aware of it otherwise. * Localisation updates from https://translatewiki.net. * Delete NearbyMapFragment & NearbyListFragment (commons-app#3885) * Fixes commons-app#3884 * Delete NearbyMapFragment & NearbyListFragment * Fixed NearbyParentFragmentPresenterTest * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Add more nearby tests (commons-app#3877) * more nearby tests added * Add tests for Label class * Add checkbox test javadocs * Add javadocs for label * Localisation updates from https://translatewiki.net. * Updated strings.xml Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Co-authored-by: Ashish Kumar <ashishkumar468@gmail.com> * Updated Strings * Added JavaDocs for all methods and classes * Added JavaDocs for all methods and classes * Added More JavaDocs * Revert string.xml * Revert "Revert string.xml" This reverts commit 00019b5. * Added protected * Fixed strings.xml extra changes * Revert codeStyle change * Fixed extra string change Co-authored-by: Vivek Maskara <maskaravivek@gmail.com> Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com> Co-authored-by: Paulina <63326136+PaulinaQuintero@users.noreply.github.com> Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Co-authored-by: Ashish Kumar <ashishkumar468@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2074
Tests performed
Tested betaDebug on Google Pixel 2 with API level 29.