Skip to content

Fixes #3547 #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Fixes #3547 #3964

merged 1 commit into from
Oct 21, 2020

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)

Fixes #3547

What changes did you make and why?
*Catch possible SqliteException while deleting ContributionsDao's entries
Tests performed (required)

Tested betaDebug Api 21

@ashishkumar468
Copy link
Collaborator Author

@sivaraam Can you help test the issue on this branch please?

@codecov-io
Copy link

Codecov Report

Merging #3964 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3964      +/-   ##
============================================
- Coverage     10.52%   10.51%   -0.01%     
  Complexity      466      466              
============================================
  Files           335      335              
  Lines         12631    12634       +3     
  Branches        988      988              
============================================
  Hits           1329     1329              
- Misses        11235    11238       +3     
  Partials         67       67              
Impacted Files Coverage Δ Complexity Δ
...n/java/fr/free/nrw/commons/CommonsApplication.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ree/nrw/commons/contributions/ContributionDao.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85bd03...c0b06e0. Read the comment docs.

@sivaraam
Copy link
Member

sivaraam commented Oct 17, 2020

@ashishkumar468 This does seem to be fixing the issue for me i.e., I'm properly logged out now. Thanks! 🙂

@maskaravivek maskaravivek merged commit 1fc8c15 into commons-app:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logout doesn't immediately log users out
4 participants