Skip to content

Make "Save Pictures" option clear #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

jidanni
Copy link
Contributor

@jidanni jidanni commented Oct 31, 2020

First, these days "External Storage / Internal storage" might not mean much, and be confusing.

Second, I have adjusted the text to what I am guessing you folks originally meant. (Not tested!)

First, these days "External Storage / Internal storage" might not mean much, and be confusing.

Second, I have adjusted the text to what I am guessing you folks originally meant. (Not tested!)
Copy link
Member

@sivaraam sivaraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the setting! I've long wanted to do this myself :)
I've left a few minor comments. Other than that this looks good.

Copy link
Member

@sivaraam sivaraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added code suggestions that can be easily used to apply the suggested changes.

PS: Forgive the force-push in between, I accidentally applied suggestions myself rather than allowing you to apply them.

@sivaraam sivaraam merged commit d4b73fa into commons-app:master Nov 2, 2020
@sivaraam
Copy link
Member

sivaraam commented Nov 2, 2020

Thanks for the PR @jidanni !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants