Skip to content

Added title name and a tooltip for all the media upload steps #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

anadi198
Copy link
Contributor

@anadi198 anadi198 commented Nov 12, 2020

Description (required)

@PaulinaQuintero We want the name of the step and then a tooltip. So for instance in your screenshot, the title would have "Step 3 of 4: Categories ["i"]".
#3757 (comment)

This PR tries to accomplish as stated above.

Fixes #3757

What changes did you make and why?

  • Changed step_count inside strings.xml to include ": [Step title here]"
  • Added necessary strings inside strings.xml
  • Added an ImageView next to the titleTV TextView for all the steps of media upload by putting them inside a horizontal LinearLayout

Tests performed (required)

Tested ProdDebug(and BetaDebug) on Realme 6 with API level 29.

Screenshots (for UI changes only)
Step 1
Step 1 tooltip
Step 2
Step 2 tooltip
Step 3
Step 3 tooltip
Step 4
Step 4 tooltip

@codecov-io
Copy link

Codecov Report

Merging #4030 (d00e6a0) into master (2ed5a74) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4030      +/-   ##
============================================
- Coverage     10.66%   10.65%   -0.01%     
  Complexity      476      476              
============================================
  Files           343      343              
  Lines         12809    12821      +12     
  Branches        995      995              
============================================
  Hits           1366     1366              
- Misses        11375    11387      +12     
  Partials         68       68              
Impacted Files Coverage Δ Complexity Δ
...ns/upload/categories/UploadCategoriesFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ee/nrw/commons/upload/depicts/DepictsFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...w/commons/upload/license/MediaLicenseFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...upload/mediaDetails/UploadMediaDetailFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed5a74...d00e6a0. Read the comment docs.

@misaochan
Copy link
Member

Wonderful, thanks @anadi198 ! :)

@misaochan misaochan merged commit c93ab86 into commons-app:master Nov 17, 2020
@anadi198 anadi198 deleted the tinyUI branch November 17, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a tiny UI element to depictions screen to distinguish from category
3 participants