Skip to content

Fixes #4051- App crashes in explore #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)
App crashes in explore

What changes did you make and why?

  • Handled possible NPE in ExploreListRootFragment

Tests performed (required)

Tested betaDebug API 27


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

* null check on mediaDetails
@codecov-io
Copy link

Codecov Report

Merging #4052 (464e3fc) into master (c93ab86) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4052      +/-   ##
============================================
- Coverage     10.65%   10.61%   -0.05%     
  Complexity      476      476              
============================================
  Files           343      343              
  Lines         12821    12871      +50     
  Branches        995      997       +2     
============================================
  Hits           1366     1366              
- Misses        11387    11437      +50     
  Partials         68       68              
Impacted Files Coverage Δ Complexity Δ
...e/nrw/commons/explore/ExploreListRootFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/fr/free/nrw/commons/utils/DialogUtil.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...w/commons/contributions/ContributionsFragment.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...commons/nearby/fragments/NearbyParentFragment.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...upload/mediaDetails/UploadMediaDetailFragment.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93ab86...464e3fc. Read the comment docs.

@maskaravivek maskaravivek merged commit 0f9d462 into commons-app:master Nov 28, 2020
@ashishkumar468 ashishkumar468 deleted the bugfix-4051 branch November 28, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes while back press in explore
3 participants