Fixes invalid authorname in explore #4054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Defined two feild author and user in Media and used them at the corresponding places Minor bug fixes -displaying userName in uploadedBy. -modified HTML parsing in getArtist. -Replaced creator with author.
* Defined two feild author and user in Media and used them at the corresponding places Minor bug fixes -displaying userName in uploadedBy. -modified HTML parsing in getArtist. -Replaced creator with author.
Codecov Report
@@ Coverage Diff @@
## master #4054 +/- ##
============================================
- Coverage 10.65% 10.61% -0.05%
Complexity 476 476
============================================
Files 343 343
Lines 12821 12874 +53
Branches 995 996 +1
============================================
Hits 1366 1366
- Misses 11387 11440 +53
Partials 68 68
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixed invalid author name in explore
Fixes #4018 & #3341 (possibly)
Ref: #3714
What changes did you make and why?
Introduced a new field "user" in Media.
modified HTML parsing in getArtist.
Replaced "creator" with "author".
removed getAuthorName.
fixed delete helper since we no longer need to remove page does not exist from the username.
Tests performed (required)
Tested betaDebugApi 27
Screenshots (for UI changes only)
