Skip to content

Fixed-Zero quantity in messages doesn't work in English #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)
Fixed-Zero quantity in messages doesn't work in English
Fixes #343

What changes did you make and why?

  • Removed the quantity item zero from string plural contributions_subtitle
  • Handled zero upload count from MainActivity

Tests performed (required)

Tested betaDebug on API 27

Removed the quantity item zero from string plural contributions_subtitle
Handled zero uplaod count from MainActivity
@codecov-io
Copy link

Codecov Report

Merging #4057 (d828ec8) into master (0f9d462) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4057      +/-   ##
============================================
- Coverage     10.61%   10.61%   -0.01%     
  Complexity      476      476              
============================================
  Files           343      343              
  Lines         12871    12872       +1     
  Branches        997      998       +1     
============================================
  Hits           1366     1366              
- Misses        11437    11438       +1     
  Partials         68       68              
Impacted Files Coverage Δ Complexity Δ
...r/free/nrw/commons/contributions/MainActivity.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9d462...d828ec8. Read the comment docs.

@misaochan
Copy link
Member

Thanks @ashishkumar468 !

@misaochan misaochan merged commit f1b4072 into commons-app:master Dec 1, 2020
@ashishkumar468 ashishkumar468 deleted the bugfix/plural-strings branch December 1, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zero quantity in messages doesn't work in English
3 participants