Shows "Location not available" despite GPS being on in Nearby tab( #3924)

[Prince-kushwaha]

Description (required)

Fixes #3924

What changes did you make and why?

Their is not an need to show an Toast message -"Nearby might not work properly, Location not available " Becouse it location work fine.

Tests performed (required)
Android Device :Redmi Y3
API:29

Screenshots

(for UI changes only)

[codecov-io]

Codecov Report

Merging #4059 (e353ebd) into master (2f2e948) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4059      +/-   ##
============================================
+ Coverage     10.51%   10.61%   +0.09%     
- Complexity      466      476      +10     
============================================
  Files           335      343       +8     
  Lines         12636    12870     +234     
  Branches        989      998       +9     
============================================
+ Hits           1329     1366      +37     
- Misses        11240    11436     +196     
- Partials         67       68       +1     

Impacted Files	Coverage Δ	Complexity Δ
...commons/nearby/fragments/NearbyParentFragment.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...e/nrw/commons/location/LocationServiceManager.java	8.42% <0.00%> (-0.28%)	0.00% <0.00%> (ø%)
...c/main/java/fr/free/nrw/commons/AboutActivity.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
.../main/java/fr/free/nrw/commons/utils/DialogUtil.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...n/java/fr/free/nrw/commons/CommonsApplication.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...n/java/fr/free/nrw/commons/auth/LoginActivity.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
.../java/fr/free/nrw/commons/di/NetworkingModule.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
.../java/fr/free/nrw/commons/upload/UploadClient.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...ava/fr/free/nrw/commons/review/ReviewActivity.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...va/fr/free/nrw/commons/campaigns/CampaignView.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
... and 48 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2e948...e353ebd. Read the comment docs.

[ashishkumar468]

Hi, the if else seems to be a valid case when the lastKnownLocation is null, can you explain why are we removing this?

[Prince-kushwaha]

When I test the app on different phone i see it work fine show that i remove toast message Nearby might not work properly, Location not available

[Prince-kushwaha]

@ashishkumar468

[heinrich5991]

I don't think that this will fix my issue. The problem wasn't that a toast appears, but rather that location is never updated. This seems to remove the error message, but not the actual problem.

[Prince-kushwaha]

@heinrich5991 it work fine in my device

[ashishkumar468]

java.lang.IllegalArgumentException: provider doesn't exist: network, this is the issue, agree with @heinrich5991, removing the toast would clearly not help.

[Prince-kushwaha]

ok i understand the issue
i try to solve this issue

[neslihanturan]

Since everyone agrees this wont solve the issue, closing.