Skip to content

fixes After click on the image app is crashed (#4072) #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2020
Merged

fixes After click on the image app is crashed (#4072) #4074

merged 1 commit into from
Dec 10, 2020

Conversation

Prince-kushwaha
Copy link
Contributor

@Prince-kushwaha Prince-kushwaha commented Dec 6, 2020

Description (required)
Fixes #4072

What changes did you make and why?
add an function setSupportActionBar(toolbar) in searchActivity.java becouse getSupportActionBar() function in MedaiDeatailsPageFragment.java give null object reference this cause to crash

Tests performed (required)
android Device :Redmi y3
API:29

Screenshots (for UI changes only)

20201206_212858

->add an function->setSupportActionBar()
->add some attributes
@Prince-kushwaha
Copy link
Contributor Author

anyone view my pullRequest

@Prince-kushwaha
Copy link
Contributor Author

@ashishkumar0207 Hi

@Prince-kushwaha
Copy link
Contributor Author

please review my pull request so i make another PR of another issue

@misaochan
Copy link
Member

Thanks @Prince-kushwaha !

@misaochan misaochan merged commit e581318 into commons-app:master Dec 10, 2020
@misaochan misaochan mentioned this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash after opening media from the explore search
2 participants