Adds more obvious display for limited connection mode #4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
misaochan
requested changes
Dec 10, 2020
app/src/main/res/values/strings.xml
Outdated
| @@ -701,6 +701,8 @@ Upload your first media by tapping on the add button.</string> | |||
| <string name="quality_images_info">Quality images are diagrams or photographs that meet certain quality standards (which are mostly technical in nature) and are valuable for Wikimedia projects</string> | |||
| <string name="resuming_upload">Resuming upload…</string> | |||
| <string name="pausing_upload">Pausing upload…</string> | |||
| <string name="limited_connection_explanation">You have enabled limited connection mode. Thus, your uploads will be pended until you disabled this mode. Once you have disabled the limited connection mode, pending uploads will resume</string> | |||
There was a problem hiding this comment.
How about "You have enabled limited connection mode. All uploads are paused and will resume once you disable this mode." ?
misaochan
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4017
What changes did you make and why?
I added a layout which appears when limited connection mode is active: