Skip to content

fix-Upload count does not get updated right away post successful upload #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

fix-Upload count does not get updated right away post successful upload #4204

merged 1 commit into from
Feb 8, 2021

Conversation

Prince-kushwaha
Copy link
Contributor

@Prince-kushwaha Prince-kushwaha commented Jan 26, 2021

Description (required)

Fixes #1984

What changes did you make and why?

Cause of Bug
when the any medai (image,video) is uploaded then number of Upload count not update
Solution
To solve this issue i implement ServiceCallback in ContriutionsFragment to update Upload count

->when an (image ,video) is uploaded then onSuccessfulUpload() function called in UploadService
then we call the ServiceCallback method updateUploadCount() function to update the total number of
contribution

Tests performed (required)

Tested {build variant, e.g. ProdDebug,betaDebug} with API level {25,29}.

->implements the Callback method to update totol number of media uploaded
@Prince-kushwaha
Copy link
Contributor Author

@neslihanturan
Copy link
Collaborator

Thanks for the proper PR title @Prince-kushwaha 👍

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Prince-kushwaha , works as intended:)

@neslihanturan neslihanturan merged commit 8384ad0 into commons-app:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload count does not get updated right away post successful upload
2 participants