Fixes #2810 Option to Remove a new language description while uploading #4206
Conversation
There was a problem hiding this comment.
Hey @maxbetton , thanks a lot for the PR. It works as intended, I have tested. The only issue is some lines of code are edited while it is not necessary (ie. using double space instead of tabs). After you revert those changes, this PR can be merged. Works as intended :)
| selectedLanguages = new HashMap<>(); | ||
| this.savedLanguageValue = savedLanguageValue; | ||
| } | ||
| public UploadMediaDetailAdapter(String savedLanguageValue) { |
There was a problem hiding this comment.
These lines shouldn't be edited for this PR. Kindly please revert them.
There was a problem hiding this comment.
thanks for your review. I auto indent with android studio and that the result. Should i modify anyway ?
There was a problem hiding this comment.
Yes, please :/ Otherwise it wont be similar with other files.
|
Hey @maxbetton , any luck with reverting irrelevant changes?:) |
|
A kindly reminder @maxbetton :) |
|
Closing this one since it seems like a sleeping PR, however it works. Anyone interested to solve the issue can implement the same code. Thanks a lot @maxbetton :) |
Description (required)
Fixes #2810
Added option to remove a language description when uploading a new photo.
Tests performed (required)
Tested betaDebug on Google Pixel 2 XL with API level 28.
Screenshots (for UI changes only)