Fixes #3790- Use WorkManagers to upload contributions #4298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use WorkManagers to process upload contributions ** Removed UploadService and Added UploadWorker to process contributions Upload ** Made nescessary changes to remove the usages of the Service from the classes ** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp
ashishkumar468
commented
Mar 21, 2021
app/build.gradle
Outdated
| } | ||
|
|
||
| android { | ||
| compileSdkVersion 28 | ||
| compileSdkVersion 29 |
There was a problem hiding this comment.
This is recommended now
ashishkumar468
commented
Mar 21, 2021
| @@ -135,8 +135,7 @@ | |||
| android:name=".review.ReviewActivity" | |||
| android:label="@string/title_activity_review" /> | |||
|
|
|||
| <service android:name=".upload.UploadService" /> | |||
There was a problem hiding this comment.
Deleted the service
Use WorkManagers to process upload contributions ** Removed UploadService and Added UploadWorker to process contributions Upload ** Made nescessary changes to remove the usages of the Service from the classes ** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp
bf3239d to
1c6e533
Compare
This reverts commit c8979fe.
|
Hi @ashishkumar468 , I have made a few tests on this PR. All tests are made on beta debug with a fresh install:
|
|
Hi @neslihanturan, can you share the logs from when the uploads don't happen |
|
Sure, would this one work? |
|
Hi @neslihanturan Thanks for sharing the logs, I am looking into it |
|
Hi @neslihanturan , I have updated the PR with a fix, verified the upload on Android 10, could you re-verify please? |
|
Hey @ashishkumar468 , thanks for the fixes. Now upload succeeded but after select the image I have just uploaded to see media details, it crashed with error: |
neslihanturan
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Thanks @ashishkumar468 , it works. Will merge right after conflicts are fixed :)
|
Hi @neslihanturan , @misaochan - I have updated the PR, synced it with the master branch to resolve merge conflicts. Please have a look. |
neslihanturan
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3790
What changes did you make and why?
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made necessary changes to remove the usages of the Service from the classes
** UI Fixes- Minor changes in the retry and cancel upload icons to give them a clickable area of 48 dp
Tests performed (required)
Tested betaDebug on Pixel 4A- API 30
Tested all possible happy cases for the following