Fixes #4287 "Tapping multiple items in explore should not be allowed" #4310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Up for review @nicolas-raoul , @neslihanturan |
nicolas-raoul
requested changes
Mar 31, 2021
app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
There's another way to solve this issue by disabling any multitaps in the activity by setting them in the manifest file. Made requested changes. |
app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Done. |
nicolas-raoul
requested changes
Apr 1, 2021
Member
nicolas-raoul
left a comment
There was a problem hiding this comment.
I tried this version for normal usage today and tested various things, it worked as expected.
The source code looks OK too.
I requested the cancellation of a small formatting change, should be OK for merging after that.
app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java
Outdated
Show resolved
Hide resolved
nicolas-raoul
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4287
What changes did you make and why?
Tests performed (required)
Tested on Nokia 6.1+ with API level 29.